Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2311433002: Fix UMA logging for net::BidirectionalStream (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, mef
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UMA logging for net::BidirectionalStream The CL fixes the UMA to use suffixes correctly. See crbug.com/643573 for more info. BUG=635548, 643573 Committed: https://crrev.com/eef1d9c826ac10c339518a86d47dfdcf8da7cec0 Cr-Commit-Position: refs/heads/master@{#416359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M net/http/bidirectional_stream.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
xunjieli
asvitkine@: PTAL. Thanks!
4 years, 3 months ago (2016-09-02 18:42:12 UTC) #2
Alexei Svitkine (slow)
LGTM Instead of two BUG= lines, just comma-separate the bugs.
4 years, 3 months ago (2016-09-02 18:46:50 UTC) #3
xunjieli
On 2016/09/02 18:46:50, Alexei Svitkine wrote: > LGTM > > Instead of two BUG= lines, ...
4 years, 3 months ago (2016-09-02 18:47:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311433002/1
4 years, 3 months ago (2016-09-02 18:47:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/273920)
4 years, 3 months ago (2016-09-02 21:01:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311433002/1
4 years, 3 months ago (2016-09-02 21:02:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 22:01:16 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 22:03:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eef1d9c826ac10c339518a86d47dfdcf8da7cec0
Cr-Commit-Position: refs/heads/master@{#416359}

Powered by Google App Engine
This is Rietveld 408576698