Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2311673002: Just disable force to ensure that bot_update really is running everywhere. (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Just disable force to ensure that bot_update really is running everywhere. This makes it so that regardless of what force is set to in the recipe, if you invoke bot_update.ensure_checkout, it will actually run. Removal of the force option (and related options) to come shortly. R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org BUG=643885 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/95f3d317e4a3fdbd135365b64f5529e6e4ad7f98

Patch Set 1 #

Messages

Total messages: 12 (4 generated)
iannucci
PTAL. This doesn't have any expectation changes in build, which means: * recipes either were ...
4 years, 3 months ago (2016-09-04 19:38:12 UTC) #1
tandrii(chromium)
LGTM, thanks Robbie!
4 years, 3 months ago (2016-09-04 20:32:20 UTC) #2
martiniss
lgtm
4 years, 3 months ago (2016-09-05 01:22:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311673002/1
4 years, 3 months ago (2016-09-06 17:34:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3119629c79963d10)
4 years, 3 months ago (2016-09-06 17:48:51 UTC) #7
iannucci
On 2016/09/06 at 17:48:51, commit-bot wrote: > Try jobs failed on following builders: > Recipe ...
4 years, 3 months ago (2016-09-06 18:08:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311673002/1
4 years, 3 months ago (2016-09-06 18:09:05 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:17:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/95f3d317e4a3fd...

Powered by Google App Engine
This is Rietveld 408576698