Remove bogus master/builder/slave/force parameters from bot_update.

Remove bogus master/builder/slave parameters from bot_update.

Bot update now always runs regardless of environmental context.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/16e7f097a7ab958c843fcc989856a47b842eb3d9

[iannucci, 2016-09-03 01:27:49]

This will have downstream effects. I want to prepare+review those CLs before
this one lands.

[iannucci, 2016-09-03 01:28:00]

but PTAL in the mean time :)

[estaab, 2016-09-03 01:52:25]

lgtm

https://codereview.chromium.org/2308193002/diff/1/recipe_modules/bot_update/e...
File recipe_modules/bot_update/example.py (right):

https://codereview.chromium.org/2308193002/diff/1/recipe_modules/bot_update/e...
recipe_modules/bot_update/example.py:125: yield api.test('forced') +
api.properties(
Drop this one now?

https://codereview.chromium.org/2308193002/diff/1/recipe_modules/bot_update/e...
recipe_modules/bot_update/example.py:137: yield api.test('off') +
api.properties(
Maybe this one too?

https://codereview.chromium.org/2308193002/diff/1/recipe_modules/bot_update/r...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://codereview.chromium.org/2308193002/diff/1/recipe_modules/bot_update/r...
recipe_modules/bot_update/resources/bot_update.py:1503: for k, v in
sorted(items.iteritems()):
Maybe add a message giving a little context, less than the 30 lines previously,
though :p

e.g. "botupdate debugging info:"

[tandrii(chromium), 2016-09-07 13:29:37]

lgtm

[iannucci, 2016-09-07 19:21:42]

https://chromiumcodereview.appspot.com/2308193002/diff/1/recipe_modules/bot_u...
File recipe_modules/bot_update/example.py (right):

https://chromiumcodereview.appspot.com/2308193002/diff/1/recipe_modules/bot_u...
recipe_modules/bot_update/example.py:125: yield api.test('forced') +
api.properties(
On 2016/09/03 at 01:52:25, estaab wrote:
> Drop this one now?

Done

https://chromiumcodereview.appspot.com/2308193002/diff/1/recipe_modules/bot_u...
recipe_modules/bot_update/example.py:137: yield api.test('off') +
api.properties(
On 2016/09/03 at 01:52:25, estaab wrote:
> Maybe this one too?

Done

https://chromiumcodereview.appspot.com/2308193002/diff/1/recipe_modules/bot_u...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://chromiumcodereview.appspot.com/2308193002/diff/1/recipe_modules/bot_u...
recipe_modules/bot_update/resources/bot_update.py:1503: for k, v in
sorted(items.iteritems()):
On 2016/09/03 at 01:52:25, estaab wrote:
> Maybe add a message giving a little context, less than the 30 lines
previously, though :p
> 
> e.g. "botupdate debugging info:"

Yeah I do this with the print statement up above :)

[iannucci, 2016-09-07 19:28:16]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:45:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:45:10]

Dry run: Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/311ef11517970610)

[iannucci, 2016-09-08 18:27:01]

Description was changed from

==========
Remove bogus master/builder/slave/force parameters from bot_update.

Bot update should always run when run from a recipe, no environment inspection
necessary.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org,
tandrii@chromium.org
BUG=643885
==========

to

==========
Remove bogus master/builder/slave parameters from bot_update.

Bot update now always runs regardless of environmental context.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org,
tandrii@chromium.org
BUG=643885
==========

[iannucci, 2016-09-08 18:27:38]

iannucci@chromium.org changed reviewers:
+ agable@chromium.org

[iannucci, 2016-09-08 18:27:39]

please take another look. Trying to keep this patch as small as possible.
There's lots more cruft to clean up as well :)

[tandrii(chromium), 2016-09-08 18:32:46]

lgtm

[agable, 2016-09-08 18:33:38]

lgtm

[Ryan Tseng, 2016-09-08 18:34:54]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2016-09-08 18:34:55]

lgtm

https://chromiumcodereview.appspot.com/2308193002/diff/60001/recipe_modules/b...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://chromiumcodereview.appspot.com/2308193002/diff/60001/recipe_modules/b...
recipe_modules/bot_update/resources/bot_update.py:1307: if active:
always active

https://chromiumcodereview.appspot.com/2308193002/diff/60001/recipe_modules/b...
recipe_modules/bot_update/resources/bot_update.py:1489: except Inactive:
not used

[iannucci, 2016-09-08 18:39:06]

https://chromiumcodereview.appspot.com/2308193002/diff/60001/recipe_modules/b...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://chromiumcodereview.appspot.com/2308193002/diff/60001/recipe_modules/b...
recipe_modules/bot_update/resources/bot_update.py:1489: except Inactive:
On 2016/09/08 at 18:34:54, Ryan Tseng wrote:
> not used

Yeah, I want to clean these things up in a future CL. Trying to keep this one
small.

[iannucci, 2016-09-08 18:39:07]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-09-08 18:39:07]

The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2308193002/#ps60001
(title: "re-do patch after recent CLs")

[commit-bot: I haz the power, 2016-09-08 18:39:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:42:16]

Description was changed from

==========
Remove bogus master/builder/slave parameters from bot_update.

Bot update now always runs regardless of environmental context.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org,
tandrii@chromium.org
BUG=643885
==========

to

==========
Remove bogus master/builder/slave parameters from bot_update.

Bot update now always runs regardless of environmental context.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org,
tandrii@chromium.org
BUG=643885

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/16e7f097a7ab95...
==========

[commit-bot: I haz the power, 2016-09-08 18:42:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/16e7f097a7ab95...