Fix type errors in sort().

Fix type errors in sort().

If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.

A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/33ff9a3d4fc3fe0cf8e12513ee27d812449a2ff2

[Bob Nystrom, 2016-09-06 21:14:55]

rnystrom@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-09-06 21:26:07]

lgtm

https://codereview.chromium.org/2311513002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_array.dart (right):

https://codereview.chromium.org/2311513002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_array.dart:467: Sort.sort(this, (a,
b) => (a as Comparable).compareTo(b));
Maybe:

(a, b) => Comparable.compare(a, b);

?

[Bob Nystrom, 2016-09-09 00:14:21]

https://codereview.chromium.org/2311513002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_array.dart (right):

https://codereview.chromium.org/2311513002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_array.dart:467: Sort.sort(this, (a,
b) => (a as Comparable).compareTo(b));
On 2016/09/06 21:26:07, vsm wrote:
> Maybe:
> 
> (a, b) => Comparable.compare(a, b);
> 
> ?

Done.

[Bob Nystrom, 2016-09-09 00:14:31]

Description was changed from

==========
Fix type errors in sort().

If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.

A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.
==========

to

==========
Fix type errors in sort().

If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.

A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/33ff9a3d4fc3fe0cf8e12513ee27...
==========

[Bob Nystrom, 2016-09-09 00:14:32]

Committed patchset #2 (id:20001) manually as
33ff9a3d4fc3fe0cf8e12513ee27d812449a2ff2 (presubmit successful).