pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart - Issue 2311513002: Fix type errors in sort().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart

Issue 2311513002: Fix type errors in sort(). (Closed)

Patch Set: Use Comparable.compare(). Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart b/pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart

index 7e6dbd3adc18306ba52249a85ea852921eec7a17..37fdf0a366cf27dd98e80e22719218d2e0815806 100644

--- a/pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart

+++ b/pkg/dev_compiler/tool/input_sdk/lib/collection/list.dart

@@ -309,7 +309,7 @@ abstract class ListMixin<E> implements List<E> {

void sort([int compare(E a, E b)]) {

if (compare == null) {

- Sort.sort(this, Comparable.compare);

+ Sort.sort(this, (a, b) => Comparable.compare(a, b));

} else {

Sort.sort(this, compare);

}