Iron out some kinks in SVG IDL files

Iron out some kinks in SVG IDL files

This drops a few "[Default=Undefined] optional" from method arguments to
match the expected arity checking behavior.
Matches Gecko and the spec where applicable.

For SVGAnimationElement.{begin,end}ElementAt, block all non-finite values
as per the WebIDL 'float' type.

BUG=311246
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171485

[eseidel, 2014-04-09 17:09:27]

These should all be testable web-facing changes, no?

[fs, 2014-04-10 07:41:46]

On 2014/04/09 17:09:27, eseidel wrote:
> These should all be testable web-facing changes, no?

Yes, but in the "trivial" category for the latter part (I hope). I've made some
tests for the error conditions already - just need to clean those up a bit.

[fs, 2014-04-10 14:12:09]

On 2014/04/10 07:41:46, fs wrote:
> On 2014/04/09 17:09:27, eseidel wrote:
> > These should all be testable web-facing changes, no?
> 
> Yes, but in the "trivial" category for the latter part (I hope). I've made
some
> tests for the error conditions already - just need to clean those up a bit.

Added tests. Dropped the change to the SVGFEMorphologyElement interface since
it's not specced, and I couldn't find any intents as to how it was supposed to
work anywhere (although it'd seem reasonable for it to work as the
setStdDeviation methods...). It was added when the primitive was implemented as
far as I could see.

[fs, 2014-04-14 15:17:59]

On 2014/04/10 14:12:09, fs wrote:
> On 2014/04/10 07:41:46, fs wrote:
> > On 2014/04/09 17:09:27, eseidel wrote:
> > > These should all be testable web-facing changes, no?
> > 
> > Yes, but in the "trivial" category for the latter part (I hope). I've made
> some
> > tests for the error conditions already - just need to clean those up a bit.
> 
> Added tests. Dropped the change to the SVGFEMorphologyElement interface since
> it's not specced, and I couldn't find any intents as to how it was supposed to
> work anywhere (although it'd seem reasonable for it to work as the
> setStdDeviation methods...). It was added when the primitive was implemented
as
> far as I could see.

@eseidel: Since you said "A" I suppose "the of the crew" expect you to say "B"
as well, so PTAL. Also, let me know if you don't agree that this CL fits in the
"Trivial" [1] category, and I'll try to compse some kind of
intent-to-fix-arity-check-and-ship mail...

[1] http://www.chromium.org/blink#trivial-changes

[eseidel, 2014-04-14 16:25:48]

lgtm

As long as this is tested, I definitely agree this is trivial.  thank you!

Presumably our behavior now matches FF as well as the spec...

[fs, 2014-04-14 17:03:18]

On 2014/04/14 16:25:48, eseidel wrote:
...
> Presumably our behavior now matches FF as well as the spec...

It should. (The [current] spec. [1.1F2] doesn't define this very well AFAIK, but
hopefully SVG2 will.)

[fs, 2014-04-14 17:03:25]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-14 17:03:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/231143002/30001

[commit-bot: I haz the power, 2014-04-14 17:14:43]

Change committed as 171485