fpdfsdk/javascript/Annot.cpp - Issue 2311343003: Make Observers into a templated class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/Annot.cpp

Issue 2311343003: Make Observers into a templated class (Closed)

Patch Set: Make Annot is-a CPDFSDK_Annot::Observer Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/Annot.cpp

diff --git a/fpdfsdk/javascript/Annot.cpp b/fpdfsdk/javascript/Annot.cpp

index ab84247baa172f13f2f3e6e5d6855a596b10c27d..d45aa6032a7b840c9a1ab07ce5854e3afe57d32c 100644

--- a/fpdfsdk/javascript/Annot.cpp

+++ b/fpdfsdk/javascript/Annot.cpp

@@ -106,5 +106,5 @@ FX_BOOL Annot::type(IJS_Context* cc,

void Annot::SetSDKAnnot(CPDFSDK_BAAnnot* annot) {

m_pAnnot = annot;

- m_pObserver.reset(new CPDFSDK_Annot::Observer(&m_pAnnot));

+ SetWatchedPtr(&m_pAnnot);

}