Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/javascript/Annot.h

Issue 2311343003: Make Observers into a templated class (Closed)
Patch Set: Make Annot is-a CPDFSDK_Annot::Observer Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/cpdfsdk_annot.h ('k') | fpdfsdk/javascript/Annot.cpp » ('j') | fpdfsdk/javascript/Field.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/Annot.h
diff --git a/fpdfsdk/javascript/Annot.h b/fpdfsdk/javascript/Annot.h
index be850350aea4cf6c02e84e5ee93a4e564737051c..c8b0afb556de0bfaf5e549705a22657ff0e2d093 100644
--- a/fpdfsdk/javascript/Annot.h
+++ b/fpdfsdk/javascript/Annot.h
@@ -12,7 +12,7 @@
#include "fpdfsdk/include/cpdfsdk_baannot.h"
#include "fpdfsdk/javascript/JS_Define.h"
-class Annot : public CJS_EmbedObj {
+class Annot : public CJS_EmbedObj, public CPDFSDK_Annot::Observer {
public:
explicit Annot(CJS_Object* pJSObject);
~Annot() override;
@@ -25,7 +25,6 @@ class Annot : public CJS_EmbedObj {
private:
CPDFSDK_Annot* m_pAnnot = nullptr;
- std::unique_ptr<CPDFSDK_Annot::Observer> m_pObserver;
};
class CJS_Annot : public CJS_Object {
« no previous file with comments | « fpdfsdk/include/cpdfsdk_annot.h ('k') | fpdfsdk/javascript/Annot.cpp » ('j') | fpdfsdk/javascript/Field.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698