Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2696)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code changed as per review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index e158759cc21ef7ac575b6bec2ffeb86aa9490a65..f15c519b28c99eb37dbc1e761536ce68ffd7a393 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -2783,26 +2783,21 @@ void LayerTreeHostImpl::AnimatePageScale(base::TimeTicks monotonic_time) {
if (!page_scale_animation_)
return;
- // TODO(ajuma): http://crbug.com/178171 - Animations use double for monotonic
- // time.
- double monotonic_time_for_cc_animations =
- (monotonic_time - base::TimeTicks()).InSecondsF();
gfx::Vector2dF scroll_total = active_tree_->TotalScrollOffset();
if (!page_scale_animation_->IsAnimationStarted())
- page_scale_animation_->StartAnimation(monotonic_time_for_cc_animations);
+ page_scale_animation_->StartAnimation(monotonic_time);
- active_tree_->SetPageScaleDelta(page_scale_animation_->PageScaleFactorAtTime(
- monotonic_time_for_cc_animations) /
- active_tree_->page_scale_factor());
- gfx::Vector2dF next_scroll = page_scale_animation_->ScrollOffsetAtTime(
- monotonic_time_for_cc_animations);
+ active_tree_->SetPageScaleDelta(
+ page_scale_animation_->PageScaleFactorAtTime(monotonic_time) /
+ active_tree_->page_scale_factor());
+ gfx::Vector2dF next_scroll =
+ page_scale_animation_->ScrollOffsetAtTime(monotonic_time);
ScrollViewportBy(next_scroll - scroll_total);
SetNeedsRedraw();
- if (page_scale_animation_->IsAnimationCompleteAtTime(
- monotonic_time_for_cc_animations)) {
+ if (page_scale_animation_->IsAnimationCompleteAtTime(monotonic_time)) {
page_scale_animation_.reset();
client_->SetNeedsCommitOnImplThread();
client_->RenewTreePriority();
@@ -2832,17 +2827,12 @@ void LayerTreeHostImpl::AnimateLayers(base::TimeTicks monotonic_time) {
return;
TRACE_EVENT0("cc", "LayerTreeHostImpl::AnimateLayers");
-
- // TODO(ajuma): http://crbug.com/178171 - Animations use double for monotonic
- // time.
- double monotonic_time_for_cc_animations =
- (monotonic_time - base::TimeTicks()).InSecondsF();
AnimationRegistrar::AnimationControllerMap copy =
animation_registrar_->active_animation_controllers();
for (AnimationRegistrar::AnimationControllerMap::iterator iter = copy.begin();
iter != copy.end();
++iter)
- (*iter).second->Animate(monotonic_time_for_cc_animations);
+ (*iter).second->Animate(monotonic_time);
SetNeedsAnimate();
}

Powered by Google App Engine
This is Rietveld 408576698