Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2284)

Unified Diff: cc/input/page_scale_animation.cc

Issue 231133002: CC::Animations should use TimeTicks & TimeDelta to represent time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code changed as per review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/input/page_scale_animation.cc
diff --git a/cc/input/page_scale_animation.cc b/cc/input/page_scale_animation.cc
index 7df0244ec0907a1466bc2ab9625c147fe075d754..9e6947d26005e3ac07d6b9c5552004e6d124e020 100644
--- a/cc/input/page_scale_animation.cc
+++ b/cc/input/page_scale_animation.cc
@@ -40,6 +40,9 @@ gfx::Vector2dF InterpolateBetween(const gfx::Vector2dF& start,
namespace cc {
+using base::TimeTicks;
+using base::TimeDelta;
+
scoped_ptr<PageScaleAnimation> PageScaleAnimation::Create(
const gfx::Vector2dF& start_scroll_offset,
float start_page_scale_factor,
@@ -66,9 +69,11 @@ PageScaleAnimation::PageScaleAnimation(
target_anchor_(),
viewport_size_(viewport_size),
root_layer_size_(root_layer_size),
- start_time_(-1.0),
- duration_(0.0),
- timing_function_(timing_function.Pass()) {}
+ start_time_(TimeTicks::FromInternalValue(
+ -1.0 * base::Time::kMicrosecondsPerSecond)),
+ duration_(),
ajuma 2014/05/07 17:04:42 Not needed.
Sikugu_ 2014/05/12 16:01:53 Done.
+ timing_function_(timing_function.Pass()) {
+}
PageScaleAnimation::~PageScaleAnimation() {}
@@ -78,7 +83,7 @@ void PageScaleAnimation::ZoomTo(const gfx::Vector2dF& target_scroll_offset,
target_page_scale_factor_ = target_page_scale_factor;
target_scroll_offset_ = target_scroll_offset;
ClampTargetScrollOffset();
- duration_ = duration;
+ duration_ = TimeDelta::FromSecondsD(duration);
if (start_page_scale_factor_ == target_page_scale_factor) {
start_anchor_ = start_scroll_offset_;
@@ -97,7 +102,7 @@ void PageScaleAnimation::ZoomWithAnchor(const gfx::Vector2dF& anchor,
double duration) {
start_anchor_ = anchor;
target_page_scale_factor_ = target_page_scale_factor;
- duration_ = duration;
+ duration_ = TimeDelta::FromSecondsD(duration);
// We start zooming out from the anchor tapped by the user. But if
// the target scale is impossible to attain without hitting the root layer
@@ -163,36 +168,38 @@ gfx::SizeF PageScaleAnimation::ViewportSizeAt(float interp) const {
}
bool PageScaleAnimation::IsAnimationStarted() const {
- return start_time_ >= 0;
+ return (start_time_ - base::TimeTicks()).InSecondsF() >= 0;
ajuma 2014/05/07 17:04:42 return start_time_ > base::TimeTicks(); is more e
ajuma 2014/05/07 17:06:49 Sorry, make that: return start_time_ >= base::Tim
Sikugu_ 2014/05/12 16:01:53 Done.
}
-void PageScaleAnimation::StartAnimation(double time) {
- DCHECK_GT(0, start_time_);
+void PageScaleAnimation::StartAnimation(base::TimeTicks time) {
+ DCHECK_GT(0, (start_time_ - base::TimeTicks()).InSecondsF());
ajuma 2014/05/07 17:04:42 DCHECK(start_time_ < base::TimeTicks()); is easie
Sikugu_ 2014/05/12 16:01:53 Done.
start_time_ = time;
}
-gfx::Vector2dF PageScaleAnimation::ScrollOffsetAtTime(double time) const {
- DCHECK_GE(start_time_, 0);
+gfx::Vector2dF PageScaleAnimation::ScrollOffsetAtTime(
+ base::TimeTicks time) const {
+ DCHECK_GE((start_time_ - base::TimeTicks()).InSecondsF(), 0);
ajuma 2014/05/07 17:04:42 DCHECK(start_time_>= base::TimeTicks());
Sikugu_ 2014/05/12 16:01:53 Done.
return ScrollOffsetAt(InterpAtTime(time));
}
-float PageScaleAnimation::PageScaleFactorAtTime(double time) const {
- DCHECK_GE(start_time_, 0);
+float PageScaleAnimation::PageScaleFactorAtTime(base::TimeTicks time) const {
+ DCHECK_GE((start_time_ - base::TimeTicks()).InSecondsF(), 0);
ajuma 2014/05/07 17:04:42 DCHECK(start_time_ >= base::TimeTicks());
Sikugu_ 2014/05/12 16:01:53 Done.
return PageScaleFactorAt(InterpAtTime(time));
}
-bool PageScaleAnimation::IsAnimationCompleteAtTime(double time) const {
- DCHECK_GE(start_time_, 0);
+bool PageScaleAnimation::IsAnimationCompleteAtTime(base::TimeTicks time) const {
+ DCHECK_GE((start_time_ - base::TimeTicks()).InSecondsF(), 0);
ajuma 2014/05/07 17:04:42 DCHECK(start_time_ >= base::TimeTicks());
Sikugu_ 2014/05/12 16:01:53 Done.
return time >= end_time();
}
-float PageScaleAnimation::InterpAtTime(double time) const {
- DCHECK_GE(start_time_, 0);
- DCHECK_GE(time, start_time_);
- if (IsAnimationCompleteAtTime(time))
+float PageScaleAnimation::InterpAtTime(base::TimeTicks monotonic_time) const {
+ DCHECK_GE((start_time_ - base::TimeTicks()).InSecondsF(), 0);
ajuma 2014/05/07 17:04:42 DCHECK(start_time_ >= base::TimeTicks());
Sikugu_ 2014/05/12 16:01:53 Done.
+ DCHECK_GE((monotonic_time - base::TimeTicks()).InSecondsF(),
+ (start_time_ - base::TimeTicks()).InSecondsF());
ajuma 2014/05/07 17:04:42 DCHECK(monotonic_time >= start_time_);
Sikugu_ 2014/05/12 16:01:53 Done.
+ if (IsAnimationCompleteAtTime(monotonic_time))
return 1.f;
-
- const double normalized_time = (time - start_time_) / duration_;
+ const double normalized_time =
+ (monotonic_time - start_time_).InSecondsF() / duration_.InSecondsF();
return timing_function_->GetValue(normalized_time);
}

Powered by Google App Engine
This is Rietveld 408576698