Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2311253003: Fix an issue that download progress notification is shown when killing browser (Closed)

Created:
4 years, 3 months ago by qinmin
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix an issue that download progress notification is shown when killing browser When browser gets killed, we should show a paused notification. However, onTaskRemoved() is often called too early before process fully stops. As a result, a progress notification can arrive after Chrome changes all the notification to paused. This may cause chrome to show a paused notification and then immediately change it to progress while killing the browser. Only progress notification matters, cancel/pause doesn't really matter. BUG=642191 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2296913002 Cr-Commit-Position: refs/heads/master@{#415439} (cherry picked from commit 540399d5f34abfcae1828e2c36835ffae391e319) Committed: https://chromium.googlesource.com/chromium/src/+/1319e021631140e015810e7ab989212700cecc3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 3 months ago (2016-09-06 18:01:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1319e021631140e015810e7ab989212700cecc3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698