Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 2296913002: Fix an issue that download progress notification is shown when killing browser (Closed)

Created:
4 years, 3 months ago by qinmin
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that download progress notification is shown when killing browser When browser gets killed, we should show a paused notification. However, onTaskRemoved() is often called too early before process fully stops. As a result, a progress notification can arrive after Chrome changes all the notification to paused. This may cause chrome to show a paused notification and then immediately change it to progress while killing the browser. Only progress notification matters, cancel/pause doesn't really matter. BUG=642191 Committed: https://crrev.com/540399d5f34abfcae1828e2c36835ffae391e319 Cr-Commit-Position: refs/heads/master@{#415439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 3 months ago (2016-08-30 19:30:41 UTC) #2
gone
lgtm
4 years, 3 months ago (2016-08-30 20:11:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296913002/1
4 years, 3 months ago (2016-08-30 20:40:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:43:57 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:45:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/540399d5f34abfcae1828e2c36835ffae391e319
Cr-Commit-Position: refs/heads/master@{#415439}

Powered by Google App Engine
This is Rietveld 408576698