Move kMaxRegularHeapObjectSize into globals

Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

R=ulan@chromium.org,bmeurer@chromium.org,vogelheim@chromium.og

Committed: https://crrev.com/059b56435ad6b6886457eaa8b1ff254b6ca0da3e
Cr-Commit-Position: refs/heads/master@{#39206}

[Michael Lippautz, 2016-09-06 12:00:04]

Description was changed from

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

BUG=
==========

to

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

BUG=
==========

[Michael Lippautz, 2016-09-06 12:03:09]

Description was changed from

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

BUG=
==========

to

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

R=ulan@chromium.org,bmeurer@chromium.org,vogelheim@chromium.og
==========

[Michael Lippautz, 2016-09-06 12:03:09]

mlippautz@chromium.org changed reviewers:
+ bmeurer@chromium.org, ulan@chromium.org, vogelheim@chromium.org

[Michael Lippautz, 2016-09-06 12:05:01]

Change is mechanical, except for the additional static assert. This allows
cleaning up heap.h to avoid exposing all internals in spaces.h. 

ptal
Benedikt: all the compilers
Daniel: snapshot/
Ulan: rest

[Benedikt Meurer, 2016-09-06 12:06:30]

Awesome, LGTM!

[vogelheim, 2016-09-06 12:08:01]

lgtm for src/snapshot/*

[Michael Lippautz, 2016-09-06 12:08:17]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 12:08:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 12:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 12:12:14]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12142)

[Michael Lippautz, 2016-09-06 12:26:30]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 12:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 12:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 12:31:32]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[Michael Lippautz, 2016-09-06 12:32:41]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 12:32:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-09-06 12:41:55]

lgtm!

[commit-bot: I haz the power, 2016-09-06 12:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 12:55:46]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-09-06 12:56:07]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-09-06 12:56:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2311203002/#ps40001
(title: "Saving the file helps...")

[commit-bot: I haz the power, 2016-09-06 12:56:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 12:59:09]

Description was changed from

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

R=ulan@chromium.org,bmeurer@chromium.org,vogelheim@chromium.og
==========

to

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

R=ulan@chromium.org,bmeurer@chromium.org,vogelheim@chromium.og
==========

[commit-bot: I haz the power, 2016-09-06 12:59:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-06 12:59:50]

Description was changed from

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

R=ulan@chromium.org,bmeurer@chromium.org,vogelheim@chromium.og
==========

to

==========
Move kMaxRegularHeapObjectSize into globals

This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

R=ulan@chromium.org,bmeurer@chromium.org,vogelheim@chromium.og

Committed: https://crrev.com/059b56435ad6b6886457eaa8b1ff254b6ca0da3e
Cr-Commit-Position: refs/heads/master@{#39206}
==========

[commit-bot: I haz the power, 2016-09-06 12:59:51]

Patchset 3 (id:??) landed as
https://crrev.com/059b56435ad6b6886457eaa8b1ff254b6ca0da3e
Cr-Commit-Position: refs/heads/master@{#39206}