Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 2311203002: Move kMaxRegularHeapObjectSize into globals (Closed)
Patch Set: Saving the file helps... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/heap/test-alloc.cc ('k') | test/cctest/heap/test-mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index e54724c1cbcb1d4201ed72a3bc40e7b595ed6f2b..ddec28030d1a781f9d525b6415efd1b1cbc5bb79 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -1254,7 +1254,7 @@ TEST(Iteration) {
factory->NewStringFromStaticChars("abcdefghij", TENURED);
// Allocate a large string (for large object space).
- int large_size = Page::kMaxRegularHeapObjectSize + 1;
+ int large_size = kMaxRegularHeapObjectSize + 1;
char* str = new char[large_size];
for (int i = 0; i < large_size - 1; ++i) str[i] = 'a';
str[large_size - 1] = '\0';
@@ -4605,8 +4605,8 @@ TEST(LargeObjectSlotRecording) {
FixedArray* old_location = *lit;
// Allocate a large object.
- int size = Max(1000000, Page::kMaxRegularHeapObjectSize + KB);
- CHECK(size > Page::kMaxRegularHeapObjectSize);
+ int size = Max(1000000, kMaxRegularHeapObjectSize + KB);
+ CHECK(size > kMaxRegularHeapObjectSize);
Handle<FixedArray> lo = isolate->factory()->NewFixedArray(size, TENURED);
CHECK(heap->lo_space()->Contains(*lo));
@@ -6483,8 +6483,8 @@ HEAP_TEST(Regress587004) {
Heap* heap = CcTest::heap();
Isolate* isolate = CcTest::i_isolate();
Factory* factory = isolate->factory();
- const int N = (Page::kMaxRegularHeapObjectSize - FixedArray::kHeaderSize) /
- kPointerSize;
+ const int N =
+ (kMaxRegularHeapObjectSize - FixedArray::kHeaderSize) / kPointerSize;
Handle<FixedArray> array = factory->NewFixedArray(N, TENURED);
CHECK(heap->old_space()->Contains(*array));
Handle<Object> number = factory->NewHeapNumber(1.0);
@@ -6595,7 +6595,7 @@ TEST(Regress598319) {
Heap* heap = CcTest::heap();
Isolate* isolate = heap->isolate();
- const int kNumberOfObjects = Page::kMaxRegularHeapObjectSize / kPointerSize;
+ const int kNumberOfObjects = kMaxRegularHeapObjectSize / kPointerSize;
struct Arr {
Arr(Isolate* isolate, int number_of_objects) {
« no previous file with comments | « test/cctest/heap/test-alloc.cc ('k') | test/cctest/heap/test-mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698