Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 23112016: Drop unused rdtsc instruction. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Drop unused rdtsc instruction. We do not use rdtsc anywhere and we won't ever use that in the future, as it is totally unusable with multicore and out of order execution. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -38 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/disasm-x64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL, red-only :-)
7 years, 4 months ago (2013-08-22 11:10:09 UTC) #1
Jakob Kummerow
LGTM due to the difficulty in using RDTSC properly. For the record, I'm generally against ...
7 years, 4 months ago (2013-08-22 11:52:36 UTC) #2
Benedikt Meurer
7 years, 4 months ago (2013-08-22 11:58:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16268.

Powered by Google App Engine
This is Rietveld 408576698