Fixing the gdrive sync item alignment to keep it centered.

Fixing the gdrive sync item alignment to keep it centered.

Beside the fact that the gdrive sync item does not have the same size as all other images (17x19px instead of 25x25px), it was also not getting centered because the assigned layouter.
The layouter needs then to be switched dynamically with the shelf alignment so that the sync item gets always centered. The time view should not be changed at all for this, since it changes the layout itself already.


BUG=180462
TEST=visual: using gdrive sync and switching (before, while or after) the sync to another alignment and the items in the tray stay always centered.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217490

[Mr4D (OOO till 08-26), 2013-08-13 19:20:20]

Please have a look!

[jennyz, 2013-08-13 20:32:50]

https://codereview.chromium.org/23112002/diff/1/ash/system/date/tray_date.cc
File ash/system/date/tray_date.cc (right):

https://codereview.chromium.org/23112002/diff/1/ash/system/date/tray_date.cc#...
ash/system/date/tray_date.cc:161:
view->SetAlignmentOverride(TrayItemView::HORIZONTAL);
You can put the fix in TrayDate:::UpdateAfterShelfAlignmentChange.

https://codereview.chromium.org/23112002/diff/1/ash/system/tray/tray_item_view.h
File ash/system/tray/tray_item_view.h (right):

https://codereview.chromium.org/23112002/diff/1/ash/system/tray/tray_item_vie...
ash/system/tray/tray_item_view.h:67: virtual void
OnShelfAlignmentChanged(aura::RootWindow* root_window) OVERRIDE;
We already have UpdateAfterShelfAlignmentChange() in TrayItemView, which will be
called upon shelf alignment changes. Don't need this one.

[Mr4D (OOO till 08-26), 2013-08-13 21:25:01]

Okay - simplified by moving the alignment to only the object handler in question
(as suggested).

https://codereview.chromium.org/23112002/diff/1/ash/system/date/tray_date.cc
File ash/system/date/tray_date.cc (right):

https://codereview.chromium.org/23112002/diff/1/ash/system/date/tray_date.cc#...
ash/system/date/tray_date.cc:161:
view->SetAlignmentOverride(TrayItemView::HORIZONTAL);
Actually - this was not about the date, but the DriveSync.

https://codereview.chromium.org/23112002/diff/1/ash/system/tray/tray_item_view.h
File ash/system/tray/tray_item_view.h (right):

https://codereview.chromium.org/23112002/diff/1/ash/system/tray/tray_item_vie...
ash/system/tray/tray_item_view.h:67: virtual void
OnShelfAlignmentChanged(aura::RootWindow* root_window) OVERRIDE;
Okay - as discussed - changed it now only in the object in question: The
TrayImageItem. If another object will show the same problem we can address it
later. (This way it is much simpler and I like simpler :) ).

[jennyz, 2013-08-13 22:01:55]

lgtm

[commit-bot: I haz the power, 2013-08-13 22:43:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/23112002/7001

[commit-bot: I haz the power, 2013-08-14 05:48:45]

Change committed as 217490