Fixing the gdrive sync item alignment to keep it centered.

ash/system/tray/tray_item_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_TRAY_TRAY_ITEM_VIEW_H_
 #define ASH_SYSTEM_TRAY_TRAY_ITEM_VIEW_H_
 
 #include "ash/ash_export.h"
+#include "ash/shell_observer.h"
 #include "ui/base/animation/animation_delegate.h"
 #include "ui/views/view.h"
 
+namespace aura {
+class RootWindow;
+}
+
 namespace ui {
 class SlideAnimation;
 }
 
 namespace views {
 class ImageView;
 class Label;
 }
 
 namespace ash {
 
 class SystemTrayItem;
 
 namespace internal {
 
 // Base-class for items in the tray. It makes sure the widget is updated
 // correctly when the visibility/size of the tray item changes. It also adds
 // animation when showing/hiding the item in the tray.
 class ASH_EXPORT TrayItemView : public views::View,
+                                public ash::ShellObserver,
                                 public ui::AnimationDelegate {
  public:
   explicit TrayItemView(SystemTrayItem* owner);
   virtual ~TrayItemView();
 
   static void DisableAnimationsForTest();
 
   // Convenience function for creating a child Label or ImageView.
   void CreateLabel();
   void CreateImageView();
 
   SystemTrayItem* owner() const { return owner_; }
   views::Label* label() const { return label_; }
   views::ImageView* image_view() const { return image_view_; }
 
+  enum AlignmentOverride {
+    AUTO,
+    HORIZONTAL,
+    VERTICAL
+  };
+
+  // Enforce a shelf alignment independent alignment for this item.
+  void SetAlignmentOverride(AlignmentOverride alignment_override);
+
   // Overridden from views::View.
   virtual void SetVisible(bool visible) OVERRIDE;
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual int GetHeightForWidth(int width) OVERRIDE;
 
+  // Overridden from ash::ShellObserver.
+  virtual void OnShelfAlignmentChanged(aura::RootWindow* root_window) OVERRIDE;

[jennyz, 2013/08/13 20:32:51]

We already have UpdateAfterShelfAlignmentChange() in TrayItemView, which will be
called upon shelf alignment changes. Don't need this one.

[Mr4D (OOO till 08-26), 2013/08/13 21:25:01]

Okay - as discussed - changed it now only in the object in question: The
TrayImageItem. If another object will show the same problem we can address it
later. (This way it is much simpler and I like simpler :) ).

+
  protected:
   // Makes sure the widget relayouts after the size/visibility of the view
   // changes.
   void ApplyChange();
 
   // This should return the desired size of the view. For most views, this
   // returns GetPreferredSize. But since this class overrides GetPreferredSize
   // for animation purposes, we allow a different way to get this size, and do
   // not allow GetPreferredSize to be overridden.
   virtual gfx::Size DesiredSize();
 
   // The default animation duration is 200ms. But each view can customize this.
   virtual int GetAnimationDurationMS();
 
  private:
   // Overridden from views::View.
   virtual void ChildPreferredSizeChanged(View* child) OVERRIDE;
 
   // Overridden from ui::AnimationDelegate.
   virtual void AnimationProgressed(const ui::Animation* animation) OVERRIDE;
   virtual void AnimationEnded(const ui::Animation* animation) OVERRIDE;
   virtual void AnimationCanceled(const ui::Animation* animation) OVERRIDE;
 
+  // Set the layout alignment of the view inside its parent from the shelf.
+  void SetLayoutAlignment();
+
   SystemTrayItem* owner_;
   scoped_ptr<ui::SlideAnimation> animation_;
   views::Label* label_;
   views::ImageView* image_view_;
 
+  // The alignment override - or |AUTO| if the shelf alignment should be used.
+  AlignmentOverride alignment_override_;
+
+
   DISALLOW_COPY_AND_ASSIGN(TrayItemView);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_TRAY_TRAY_ITEM_VIEW_H_