Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded

Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded

By doing this, we simplify the code in cpvt_generateap.cpp,
and avoid calling CPVT_GenerateAP methods altogether,
when it is known that they are bailing out.

This is a preparation to fix pdfium bug 585.

BUG=pdfium:585
Committed: https://pdfium.googlesource.com/pdfium/+/921d58f43cbf0dc3f12394b80cb315d00ee0bd35

[tonikitoo, 2016-09-05 09:51:22]

Description was changed from

==========
Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded

By doing this, we simplify the code in cpvt_generateap.cpp,
and avoid calling CPVT_GenerateAP methods altogether,
when it is known that they are bailing out.

This is a preparation to fix pdfium bug 585.

BUG=pdfium:585
==========

to

==========
Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded

By doing this, we simplify the code in cpvt_generateap.cpp,
and avoid calling CPVT_GenerateAP methods altogether,
when it is known that they are bailing out.

This is a preparation to fix pdfium bug 585.

BUG=pdfium:585
==========

[tonikitoo, 2016-09-05 09:51:22]

tonikitoo@igalia.com changed reviewers:
+ dsinclair@chromium.org, jaepark@google.com, tsepez@chromium.org

[tonikitoo, 2016-09-05 09:51:32]

PTAL

[dsinclair, 2016-09-06 13:02:44]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-06 13:02:44]

lgtm

[commit-bot: I haz the power, 2016-09-06 13:02:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 13:14:10]

Description was changed from

==========
Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded

By doing this, we simplify the code in cpvt_generateap.cpp,
and avoid calling CPVT_GenerateAP methods altogether,
when it is known that they are bailing out.

This is a preparation to fix pdfium bug 585.

BUG=pdfium:585
==========

to

==========
Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded

By doing this, we simplify the code in cpvt_generateap.cpp,
and avoid calling CPVT_GenerateAP methods altogether,
when it is known that they are bailing out.

This is a preparation to fix pdfium bug 585.

BUG=pdfium:585

Committed:
https://pdfium.googlesource.com/pdfium/+/921d58f43cbf0dc3f12394b80cb315d00ee0...
==========

[commit-bot: I haz the power, 2016-09-06 13:14:11]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/921d58f43cbf0dc3f12394b80cb315d00ee0...