Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2310873002: Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded (Closed)

Created:
1 year, 2 months ago by tonikitoo
Modified:
1 year, 2 months ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move ShouldGenerateAPForAnnotation check to CPDF_Annot::GenerateAPIfNeeded By doing this, we simplify the code in cpvt_generateap.cpp, and avoid calling CPVT_GenerateAP methods altogether, when it is known that they are bailing out. This is a preparation to fix pdfium bug 585. BUG=pdfium:585 Committed: https://pdfium.googlesource.com/pdfium/+/921d58f43cbf0dc3f12394b80cb315d00ee0bd35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -34 lines) Patch
M core/fpdfdoc/cpdf_annot.cpp View 3 chunks +17 lines, -1 line 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 9 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tonikitoo
PTAL
1 year, 2 months ago (2016-09-05 09:51:32 UTC) #3
dsinclair
lgtm
1 year, 2 months ago (2016-09-06 13:02:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310873002/1
1 year, 2 months ago (2016-09-06 13:02:52 UTC) #6
commit-bot: I haz the power
1 year, 2 months ago (2016-09-06 13:14:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/921d58f43cbf0dc3f12394b80cb315d00ee0...

Powered by Google App Engine
This is Rietveld efc10ee0f