Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2310863002: [gn] Switch win clang bot to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch win clang bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588 Cr-Commit-Position: refs/heads/master@{#39156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M infra/mb/mb_config.pyl View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Michael Achenbach
PTAL. Flying rather blind with this one. Trybot doesn't exist. But the bot is nearly ...
4 years, 3 months ago (2016-09-05 09:41:15 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-05 09:43:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310863002/1
4 years, 3 months ago (2016-09-05 10:47:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 10:54:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588 Cr-Commit-Position: refs/heads/master@{#39156}
4 years, 3 months ago (2016-09-05 10:55:04 UTC) #10
Michael Achenbach
4 years, 3 months ago (2016-09-05 11:07:36 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2311853002/ by machenbach@chromium.org.

The reason for reverting is: Fails compilation:
https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang.

Powered by Google App Engine
This is Rietveld 408576698