Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2309263002: [gn] Switch linux asan to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
alph, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch linux asan to gn Also disable four cpu-profiler tests under asan that fail with the GN setup. BUG=chromium:474921, v8:5243 Committed: https://crrev.com/6c335b7aae8516afc4b79a1321762593734290f6 Cr-Commit-Position: refs/heads/master@{#39171}

Patch Set 1 #

Patch Set 2 : [gn] Switch linux asan to gn #

Patch Set 3 : use minimal symbols like chromium #

Patch Set 4 : Don't incorporate symbol level change #

Patch Set 5 : Rebase #

Patch Set 6 : Skip failing tests (subissue to fix) #

Patch Set 7 : One more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M infra/mb/mb_config.pyl View 1 2 3 4 4 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Achenbach
PTAL. Flag comparison: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/14970/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/8147/steps/compare%20build%20flags%20%28fyi%29/logs/stdio The three cpu profiler failures will be investigated in http://crbug.com/v8/5243 ...
4 years, 3 months ago (2016-09-05 12:27:11 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-05 12:31:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309263002/120001
4 years, 3 months ago (2016-09-05 12:41:33 UTC) #12
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-09-05 13:16:17 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 13:16:46 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/6c335b7aae8516afc4b79a1321762593734290f6
Cr-Commit-Position: refs/heads/master@{#39171}

Powered by Google App Engine
This is Rietveld 408576698