Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2310693002: Use safe bool conversion operators in fpdf_page/ (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use safe bool conversion operators in fpdf_page/ Committed: https://pdfium.googlesource.com/pdfium/+/7b36672405c05037709a7ba3e8cc96efe2471408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_colorstate.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_contentmark.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_generalstate.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_path.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Lei, follow-up to issue found in https://codereview.chromium.org/2301263003/
4 years, 3 months ago (2016-09-03 00:19:22 UTC) #2
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-03 00:28:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310693002/1
4 years, 3 months ago (2016-09-04 00:09:57 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 00:10:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7b36672405c05037709a7ba3e8cc96efe247...

Powered by Google App Engine
This is Rietveld 408576698