Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2213)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)
Patch Set: remove scoped_vector includes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index cfd8ba1316b94777c6c2c993b93f40956a8acbfb..4be4f7f11af12c9b16c00e2e5472a45c8e813c2a 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -231,20 +231,22 @@ bool ExtensionService::OnExternalExtensionUpdateUrlFound(
void ExtensionService::OnExternalProviderUpdateComplete(
const ExternalProviderInterface* provider,
- const ScopedVector<ExternalInstallInfoUpdateUrl>& update_url_extensions,
- const ScopedVector<ExternalInstallInfoFile>& file_extensions,
+ const std::vector<std::unique_ptr<ExternalInstallInfoUpdateUrl>>&
+ update_url_extensions,
+ const std::vector<std::unique_ptr<ExternalInstallInfoFile>>&
+ file_extensions,
const std::set<std::string>& removed_extensions) {
// Update pending_extension_manager() with the new extensions first.
- for (auto* extension : update_url_extensions)
+ for (const auto& extension : update_url_extensions)
OnExternalExtensionUpdateUrlFound(*extension, false);
- for (auto* extension : file_extensions)
+ for (const auto& extension : file_extensions)
OnExternalExtensionFileFound(*extension);
#if DCHECK_IS_ON()
for (const std::string& id : removed_extensions) {
- for (auto* extension : update_url_extensions)
+ for (const auto& extension : update_url_extensions)
DCHECK_NE(id, extension->extension_id);
- for (auto* extension : file_extensions)
+ for (const auto& extension : file_extensions)
DCHECK_NE(id, extension->extension_id);
}
#endif
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698