Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5034)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)
Patch Set: remove scoped_vector includes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 604796b7b218d5827eaeb5ffaa3f59672c1800a2..57e06b16b10c20d0e631723bb0c258b299b12b7f 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -466,8 +466,10 @@ class MockProviderVisitor
void OnExternalProviderUpdateComplete(
const ExternalProviderInterface* provider,
- const ScopedVector<ExternalInstallInfoUpdateUrl>& update_url_extensions,
- const ScopedVector<ExternalInstallInfoFile>& file_extensions,
+ const std::vector<std::unique_ptr<ExternalInstallInfoUpdateUrl>>&
+ update_url_extensions,
+ const std::vector<std::unique_ptr<ExternalInstallInfoFile>>&
+ file_extensions,
const std::set<std::string>& removed_extensions) override {
ADD_FAILURE() << "MockProviderVisitor does not provide incremental updates,"
" use MockUpdateProviderVisitor instead.";
@@ -535,14 +537,16 @@ class MockUpdateProviderVisitor : public MockProviderVisitor {
void OnExternalProviderUpdateComplete(
const ExternalProviderInterface* provider,
- const ScopedVector<ExternalInstallInfoUpdateUrl>& update_url_extensions,
- const ScopedVector<ExternalInstallInfoFile>& file_extensions,
+ const std::vector<std::unique_ptr<ExternalInstallInfoUpdateUrl>>&
+ update_url_extensions,
+ const std::vector<std::unique_ptr<ExternalInstallInfoFile>>&
+ file_extensions,
const std::set<std::string>& removed_extensions) override {
- for (auto* extension_info : update_url_extensions)
+ for (const auto& extension_info : update_url_extensions)
update_url_extension_ids_.insert(extension_info->extension_id);
EXPECT_EQ(update_url_extension_ids_.size(), update_url_extensions.size());
- for (auto* extension_info : file_extensions)
+ for (const auto& extension_info : file_extensions)
file_extension_ids_.insert(extension_info->extension_id);
EXPECT_EQ(file_extension_ids_.size(), file_extensions.size());
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/external_policy_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698