components/sync/device_info/device_info_service.h - Issue 2310683002: Remove most ScopedVector usage from c/b/extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/device_info/device_info_service.h

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)

Patch Set: fix webstore_api Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/device_info/device_info_service.h

diff --git a/components/sync/device_info/device_info_service.h b/components/sync/device_info/device_info_service.h

index 40096e900ab945fe388e01efe4226389f7b385e1..1e90982257524b5c4ee180e536c2fca1fa481cfc 100644

--- a/components/sync/device_info/device_info_service.h

+++ b/components/sync/device_info/device_info_service.h

@@ -72,7 +72,8 @@ class DeviceInfoService : public syncer_v2::ModelTypeService,

bool IsSyncing() const override;

std::unique_ptr<sync_driver::DeviceInfo> GetDeviceInfo(

const std::string& client_id) const override;

- ScopedVector<sync_driver::DeviceInfo> GetAllDeviceInfo() const override;

+ std::vector<std::unique_ptr<sync_driver::DeviceInfo>> GetAllDeviceInfo()

+ const override;

void AddObserver(Observer* observer) override;

void RemoveObserver(Observer* observer) override;

int CountActiveDevices() const override;