components/sync/device_info/device_info_service.cc - Issue 2310683002: Remove most ScopedVector usage from c/b/extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/device_info/device_info_service.cc

Issue 2310683002: Remove most ScopedVector usage from c/b/extensions. (Closed)

Patch Set: fix webstore_api Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/device_info/device_info_service.cc

diff --git a/components/sync/device_info/device_info_service.cc b/components/sync/device_info/device_info_service.cc

index bc4f85c7f821990366fe7de38fdf8d0fa0e1eaaa..e02042510a096c95313a775487532e458d447060 100644

--- a/components/sync/device_info/device_info_service.cc

+++ b/components/sync/device_info/device_info_service.cc

@@ -230,8 +230,9 @@ std::unique_ptr<DeviceInfo> DeviceInfoService::GetDeviceInfo(

return CopyToModel(*iter->second);

}

-ScopedVector<DeviceInfo> DeviceInfoService::GetAllDeviceInfo() const {

- ScopedVector<DeviceInfo> list;

+std::vector<std::unique_ptr<DeviceInfo>> DeviceInfoService::GetAllDeviceInfo()

+ const {

+ std::vector<std::unique_ptr<DeviceInfo>> list;

for (ClientIdToSpecifics::const_iterator iter = all_data_.begin();

iter != all_data_.end(); ++iter) {