Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: gypfiles/toolchain.gypi

Issue 2310513002: Use -fno-delete-null-pointer-checks with gcc builds (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypfiles/toolchain.gypi
diff --git a/gypfiles/toolchain.gypi b/gypfiles/toolchain.gypi
index 95eb1d99cbff3f1172153e8652c02e6e83f82d7e..28265fbdf209c9bc1e18fa08d4cd3ac325e024b0 100644
--- a/gypfiles/toolchain.gypi
+++ b/gypfiles/toolchain.gypi
@@ -1098,6 +1098,14 @@
}],
], # conditions
}],
+ # GCC 6+ can optimize away pointer comparisons to null. This is
+ # problematic as V8 encodes Values through tagged pointers and comparisons
+ # with 0 are actually necessary in many cases. As a temporary Workaround
+ # we disable this optimization. See:
+ # https://bugs.chromium.org/p/v8/issues/detail?id=3782
Michael Achenbach 2016/09/05 06:53:39 nit: short link: crbug.com/v8/3782
ofrobots 2016/09/07 00:36:39 Done.
+ ['OS!="win" and clang==0', {
+ 'cflags': [ '-fno-delete-null-pointer-checks' ]
Michael Achenbach 2016/09/05 06:53:39 Please also add the GN configs as our bots testing
ofrobots 2016/09/07 00:36:39 Done.
+ }],
['OS=="solaris"', {
'defines': [ '__C99FEATURES__=1' ], # isinf() etc.
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698