Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: gypfiles/toolchain.gypi

Issue 2310513002: Use -fno-delete-null-pointer-checks with gcc builds (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 1080 matching lines...) Expand 10 before | Expand all | Expand 10 after
1091 ], 1091 ],
1092 }], 1092 }],
1093 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \ 1093 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
1094 or OS=="netbsd" or OS=="qnx" or OS=="aix"', { 1094 or OS=="netbsd" or OS=="qnx" or OS=="aix"', {
1095 'conditions': [ 1095 'conditions': [
1096 [ 'v8_no_strict_aliasing==1', { 1096 [ 'v8_no_strict_aliasing==1', {
1097 'cflags': [ '-fno-strict-aliasing' ], 1097 'cflags': [ '-fno-strict-aliasing' ],
1098 }], 1098 }],
1099 ], # conditions 1099 ], # conditions
1100 }], 1100 }],
1101 # GCC 6+ can optimize away pointer comparisons to null. This is
1102 # problematic as V8 encodes Values through tagged pointers and comparisons
1103 # with 0 are actually necessary in many cases. As a temporary Workaround
1104 # we disable this optimization. See:
1105 # https://bugs.chromium.org/p/v8/issues/detail?id=3782
Michael Achenbach 2016/09/05 06:53:39 nit: short link: crbug.com/v8/3782
ofrobots 2016/09/07 00:36:39 Done.
1106 ['OS!="win" and clang==0', {
1107 'cflags': [ '-fno-delete-null-pointer-checks' ]
Michael Achenbach 2016/09/05 06:53:39 Please also add the GN configs as our bots testing
ofrobots 2016/09/07 00:36:39 Done.
1108 }],
1101 ['OS=="solaris"', { 1109 ['OS=="solaris"', {
1102 'defines': [ '__C99FEATURES__=1' ], # isinf() etc. 1110 'defines': [ '__C99FEATURES__=1' ], # isinf() etc.
1103 }], 1111 }],
1104 ['OS=="freebsd" or OS=="openbsd"', { 1112 ['OS=="freebsd" or OS=="openbsd"', {
1105 'cflags': [ '-I/usr/local/include' ], 1113 'cflags': [ '-I/usr/local/include' ],
1106 }], 1114 }],
1107 ['OS=="netbsd"', { 1115 ['OS=="netbsd"', {
1108 'cflags': [ '-I/usr/pkg/include' ], 1116 'cflags': [ '-I/usr/pkg/include' ],
1109 }], 1117 }],
1110 ['OS=="aix"', { 1118 ['OS=="aix"', {
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
1411 ], 1419 ],
1412 }, 1420 },
1413 'Release_x64': { 1421 'Release_x64': {
1414 'inherit_from': ['ReleaseBase'], 1422 'inherit_from': ['ReleaseBase'],
1415 }, 1423 },
1416 }], 1424 }],
1417 ], 1425 ],
1418 }, # configurations 1426 }, # configurations
1419 }, # target_defaults 1427 }, # target_defaults
1420 } 1428 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698