Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2310493002: Fix DefaultComponentInstaller::FinishRegistration and group policy. (Closed)

Created:
4 years, 3 months ago by Sorin Jianu
Modified:
4 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix DefaultComponentInstaller::FinishRegistration and group policy. The code in DefaultComponentInstaller::FinishRegistration is not updating the value of CrxComponent::supports_group_policy_enable_component_updates with the value provided by the specific installer traits. Therefore, the components using the DefaultComponentInstaller for their installer ignore the group policy settings for controlling the update behavior. BUG=642148 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2292463004 Cr-Commit-Position: refs/heads/master@{#415110} (cherry picked from commit 098a4a79496d92de9f1740b84cc45bd2b2713292) Merging into M54 branch 2840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/component_updater/default_component_installer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/component_updater/default_component_installer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
waffles
lgtm
4 years, 3 months ago (2016-09-02 18:30:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310493002/1
4 years, 3 months ago (2016-09-02 18:32:33 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-02 18:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310493002/1
4 years, 3 months ago (2016-09-02 18:42:25 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:45:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698