Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2292463004: Fix DefaultComponentInstaller::FinishRegistration and group policy. (Closed)

Created:
4 years, 3 months ago by Sorin Jianu
Modified:
4 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DefaultComponentInstaller::FinishRegistration and group policy. The code in DefaultComponentInstaller::FinishRegistration is not updating the value of CrxComponent::supports_group_policy_enable_component_updates with the value provided by the specific installer traits. Therefore, the components using the DefaultComponentInstaller for their installer ignore the group policy settings for controlling the update behavior. BUG=642148 Committed: https://crrev.com/098a4a79496d92de9f1740b84cc45bd2b2713292 Cr-Commit-Position: refs/heads/master@{#415110}

Patch Set 1 #

Patch Set 2 : nop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/component_updater/default_component_installer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/component_updater/default_component_installer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Sorin Jianu
4 years, 3 months ago (2016-08-29 21:57:10 UTC) #3
waffles
lgtm
4 years, 3 months ago (2016-08-29 22:01:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292463004/20001
4 years, 3 months ago (2016-08-30 02:14:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 04:43:46 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:46:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/098a4a79496d92de9f1740b84cc45bd2b2713292
Cr-Commit-Position: refs/heads/master@{#415110}

Powered by Google App Engine
This is Rietveld 408576698