Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2310233002: Correct multicol dirty rect for scrolled and flipped blocks writing mode. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
chrishtr, eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct multicol dirty rect for scrolled and flipped blocks writing mode. Calling LayoutBox::location() to make a physical rectangle relative to the multicol container instead of the flowthread isn't going to work if writing mode is with flipped blocks direction (vertical-rl), because location() returns a semi-logical offset. It would have worked with topLeftLocation(), though. But since we'd still have issues with scrolling, make the dirty rectangle relative to the multicol container right away on the PaintLayer side instead, since layers know how they have been scrolled. This also happens to be in line with the comment there, so now we're actually doing what we say that we're doing. :) This makes fast/repaint/paged-with-overflowing-block-rl.html pass. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/63f8653d14ff2fac6e6ce102652aacd78966ca34 Cr-Commit-Position: refs/heads/master@{#416859}

Patch Set 1 #

Patch Set 2 : Rebaseline. #

Messages

Total messages: 14 (6 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-06 21:21:27 UTC) #3
chrishtr
lgtm
4 years, 3 months ago (2016-09-06 21:46:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310233002/20001
4 years, 3 months ago (2016-09-06 21:47:19 UTC) #6
eae
LGTM
4 years, 3 months ago (2016-09-06 21:51:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/291500)
4 years, 3 months ago (2016-09-06 23:34:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310233002/20001
4 years, 3 months ago (2016-09-07 05:20:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 06:12:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 06:13:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63f8653d14ff2fac6e6ce102652aacd78966ca34
Cr-Commit-Position: refs/heads/master@{#416859}

Powered by Google App Engine
This is Rietveld 408576698