Correct multicol dirty rect for scrolled and flipped blocks writing mode.

Correct multicol dirty rect for scrolled and flipped blocks writing mode.

Calling LayoutBox::location() to make a physical rectangle relative to the
multicol container instead of the flowthread isn't going to work if writing
mode is with flipped blocks direction (vertical-rl), because location() returns
a semi-logical offset. It would have worked with topLeftLocation(), though.
But since we'd still have issues with scrolling, make the dirty rectangle
relative to the multicol container right away on the PaintLayer side instead,
since layers know how they have been scrolled. This also happens to be in line
with the comment there, so now we're actually doing what we say that we're
doing. :)

This makes fast/repaint/paged-with-overflowing-block-rl.html pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/63f8653d14ff2fac6e6ce102652aacd78966ca34
Cr-Commit-Position: refs/heads/master@{#416859}

[mstensho (USE GERRIT), 2016-09-06 19:56:13]

Description was changed from

==========
Correct multicol dirty rect for scrolled and flipped blocks writing mode.

Calling LayoutBox::location() to make a physical rectangle relative to the
multicol container instead of the flowthread isn't going to work if writing
mode is with flipped blocks direction (vertical-rl), because location() returns
a semi-logical offset. It would have worked with topLeftLocation(), though.
But since we'd still have issues with scrolling, make the dirty rectangle
relative to the multicol container right away on the PaintLayer side instead,
since layers know how they have been scrolled. This also happens to be in line
with the comment there, so now we're actually doing what we say that we're
doing. :)

This makes fast/repaint/paged-with-overflowing-block-rl.html pass.
==========

to

==========
Correct multicol dirty rect for scrolled and flipped blocks writing mode.

Calling LayoutBox::location() to make a physical rectangle relative to the
multicol container instead of the flowthread isn't going to work if writing
mode is with flipped blocks direction (vertical-rl), because location() returns
a semi-logical offset. It would have worked with topLeftLocation(), though.
But since we'd still have issues with scrolling, make the dirty rectangle
relative to the multicol container right away on the PaintLayer side instead,
since layers know how they have been scrolled. This also happens to be in line
with the comment there, so now we're actually doing what we say that we're
doing. :)

This makes fast/repaint/paged-with-overflowing-block-rl.html pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[mstensho (USE GERRIT), 2016-09-06 21:21:26]

mstensho@opera.com changed reviewers:
+ chrishtr@chromium.org, eae@chromium.org

[chrishtr, 2016-09-06 21:46:48]

lgtm

[chrishtr, 2016-09-06 21:46:50]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-09-06 21:51:07]

LGTM

[commit-bot: I haz the power, 2016-09-06 23:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:34:28]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mstensho (USE GERRIT), 2016-09-07 05:19:55]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-09-07 05:20:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 06:12:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 06:13:40]

Description was changed from

==========
Correct multicol dirty rect for scrolled and flipped blocks writing mode.

Calling LayoutBox::location() to make a physical rectangle relative to the
multicol container instead of the flowthread isn't going to work if writing
mode is with flipped blocks direction (vertical-rl), because location() returns
a semi-logical offset. It would have worked with topLeftLocation(), though.
But since we'd still have issues with scrolling, make the dirty rectangle
relative to the multicol container right away on the PaintLayer side instead,
since layers know how they have been scrolled. This also happens to be in line
with the comment there, so now we're actually doing what we say that we're
doing. :)

This makes fast/repaint/paged-with-overflowing-block-rl.html pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Correct multicol dirty rect for scrolled and flipped blocks writing mode.

Calling LayoutBox::location() to make a physical rectangle relative to the
multicol container instead of the flowthread isn't going to work if writing
mode is with flipped blocks direction (vertical-rl), because location() returns
a semi-logical offset. It would have worked with topLeftLocation(), though.
But since we'd still have issues with scrolling, make the dirty rectangle
relative to the multicol container right away on the PaintLayer side instead,
since layers know how they have been scrolled. This also happens to be in line
with the comment there, so now we're actually doing what we say that we're
doing. :)

This makes fast/repaint/paged-with-overflowing-block-rl.html pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/63f8653d14ff2fac6e6ce102652aacd78966ca34
Cr-Commit-Position: refs/heads/master@{#416859}
==========

[commit-bot: I haz the power, 2016-09-07 06:13:41]

Patchset 2 (id:??) landed as
https://crrev.com/63f8653d14ff2fac6e6ce102652aacd78966ca34
Cr-Commit-Position: refs/heads/master@{#416859}