Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

Issue 2310233002: Correct multicol dirty rect for scrolled and flipped blocks writing mode. (Closed)
Patch Set: Rebaseline. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // content as tall as |contentLogicalHeight|. |flowThreadOffset| is expected to be at the exact 110 // content as tall as |contentLogicalHeight|. |flowThreadOffset| is expected to be at the exact
111 // top of a column that's known to not have enough space for |contentLogical Height|. This method 111 // top of a column that's known to not have enough space for |contentLogical Height|. This method
112 // is called when the current column is too short to fit the content, in the hope that there 112 // is called when the current column is too short to fit the content, in the hope that there
113 // exists one that's tall enough further ahead. If no such column can be fou nd, 113 // exists one that's tall enough further ahead. If no such column can be fou nd,
114 // |flowThreadOffset| will be returned. 114 // |flowThreadOffset| will be returned.
115 LayoutUnit nextLogicalTopForUnbreakableContent(LayoutUnit flowThreadOffset, LayoutUnit contentLogicalHeight) const; 115 LayoutUnit nextLogicalTopForUnbreakableContent(LayoutUnit flowThreadOffset, LayoutUnit contentLogicalHeight) const;
116 116
117 virtual bool isPageLogicalHeightKnown() const { return true; } 117 virtual bool isPageLogicalHeightKnown() const { return true; }
118 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; } 118 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }
119 119
120 void collectLayerFragments(PaintLayerFragments&, const LayoutRect& layerBoun dingBox, const LayoutRect& dirtyRectInFlowThread); 120 void collectLayerFragments(PaintLayerFragments&, const LayoutRect& layerBoun dingBox, const LayoutRect& dirtyRectInMulticolContainer);
121 121
122 // Return the visual bounding box based on the supplied flow-thread bounding box. Both 122 // Return the visual bounding box based on the supplied flow-thread bounding box. Both
123 // rectangles are completely physical in terms of writing mode. 123 // rectangles are completely physical in terms of writing mode.
124 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox) const; 124 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox) const;
125 125
126 // Convert a logical position in the flow thread coordinate space to a logic al position in the 126 // Convert a logical position in the flow thread coordinate space to a logic al position in the
127 // containing coordinate space. 127 // containing coordinate space.
128 void flowThreadToContainingCoordinateSpace(LayoutUnit& blockPosition, Layout Unit& inlinePosition) const; 128 void flowThreadToContainingCoordinateSpace(LayoutUnit& blockPosition, Layout Unit& inlinePosition) const;
129 129
130 virtual LayoutPoint flowThreadPointToVisualPoint(const LayoutPoint& flowThre adPoint) const = 0; 130 virtual LayoutPoint flowThreadPointToVisualPoint(const LayoutPoint& flowThre adPoint) const = 0;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // These structures are used by PODIntervalTree for debugging. 172 // These structures are used by PODIntervalTree for debugging.
173 #ifndef NDEBUG 173 #ifndef NDEBUG
174 template <> struct ValueToString<LayoutMultiColumnSet*> { 174 template <> struct ValueToString<LayoutMultiColumnSet*> {
175 static String toString(const LayoutMultiColumnSet* value) { return String::f ormat("%p", value); } 175 static String toString(const LayoutMultiColumnSet* value) { return String::f ormat("%p", value); }
176 }; 176 };
177 #endif 177 #endif
178 178
179 } // namespace blink 179 } // namespace blink
180 180
181 #endif // LayoutFlowThread_h 181 #endif // LayoutFlowThread_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698