Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: third_party/WebKit/Source/core/editing/CaretBase.cpp

Issue 2310173002: Paint carets at pixel-snapped positions. (Closed)
Patch Set: none Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/caret/caret-subpixel-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 210
211 Element* element; 211 Element* element;
212 if (node->isElementNode()) 212 if (node->isElementNode())
213 element = toElement(node); 213 element = toElement(node);
214 else 214 else
215 element = node->parentElement(); 215 element = node->parentElement();
216 216
217 if (element && element->layoutObject()) 217 if (element && element->layoutObject())
218 caretColor = element->layoutObject()->resolveColor(CSSPropertyColor); 218 caretColor = element->layoutObject()->resolveColor(CSSPropertyColor);
219 219
220 DrawingRecorder drawingRecorder(context, *this, DisplayItem::kCaret, FloatRe ct(drawingRect)); 220 IntRect paintRect = pixelSnappedIntRect(drawingRect);
221 221 DrawingRecorder drawingRecorder(context, *this, DisplayItem::kCaret, paintRe ct);
222 context.fillRect(FloatRect(drawingRect), caretColor); 222 context.fillRect(paintRect, caretColor);
223 } 223 }
224 224
225 void CaretBase::setCaretVisibility(CaretVisibility visibility) 225 void CaretBase::setCaretVisibility(CaretVisibility visibility)
226 { 226 {
227 m_caretVisibility = visibility; 227 m_caretVisibility = visibility;
228 } 228 }
229 229
230 String CaretBase::debugName() const 230 String CaretBase::debugName() const
231 { 231 {
232 return "Caret"; 232 return "Caret";
233 } 233 }
234 234
235 LayoutRect CaretBase::visualRect() const 235 LayoutRect CaretBase::visualRect() const
236 { 236 {
237 return m_visualRect; 237 return m_visualRect;
238 } 238 }
239 239
240 } // namespace blink 240 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/caret/caret-subpixel-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698