Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 231013003: Remove Sync JS generic request/reply framework (Closed)

Created:
6 years, 8 months ago by rlarocque
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Remove Sync JS generic request/reply framework With the conversion of GetAllNodes in r262193, there are no longer any uses of the Sync JS framework's request + reply framework. The generic framework was useful when we could guarantee that the requests would be handled in order, in the SyncManager, and on the sync thread, but new requirements have forced us to re-implement much of this functionality in other ways. Since no one uses this code, and no one plans to use this code, and it depends on some semi-deprecated concepts (WeakHandle), the best course of action seems to be to delete it. We can always fetch it from SVN history and clean it up if we find another use for it. BUG=328606, 357821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263105

Patch Set 1 #

Patch Set 2 : Undo one file removal #

Patch Set 3 : Add license #

Patch Set 4 : Remove js_reply_handler.h from gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -433 lines) Patch
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/js_sync_encryption_handler_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M sync/js/README.js View 1 2 1 chunk +16 lines, -48 lines 0 comments Download
D sync/js/js_arg_list.h View 1 chunk +0 lines, -44 lines 0 comments Download
D sync/js/js_arg_list.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D sync/js/js_arg_list_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M sync/js/js_backend.h View 2 chunks +0 lines, -8 lines 0 comments Download
M sync/js/js_controller.h View 2 chunks +0 lines, -8 lines 0 comments Download
D sync/js/js_reply_handler.h View 1 chunk +0 lines, -29 lines 0 comments Download
M sync/js/js_test_util.h View 5 chunks +0 lines, -26 lines 0 comments Download
M sync/js/js_test_util.cc View 3 chunks +0 lines, -47 lines 0 comments Download
M sync/js/sync_js_controller.h View 2 chunks +0 lines, -22 lines 0 comments Download
M sync/js/sync_js_controller.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M sync/js/sync_js_controller_unittest.cc View 2 chunks +0 lines, -86 lines 0 comments Download
M sync/sync_core.gypi View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
rlarocque
Please review.
6 years, 8 months ago (2014-04-09 20:30:43 UTC) #1
tim (not reviewing)
lgtm
6 years, 8 months ago (2014-04-10 02:23:33 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-10 17:06:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/231013003/20001
6 years, 8 months ago (2014-04-10 17:06:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 18:00:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60675
6 years, 8 months ago (2014-04-10 18:00:25 UTC) #6
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-10 18:05:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/231013003/40001
6 years, 8 months ago (2014-04-10 18:05:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 19:09:59 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 8 months ago (2014-04-10 19:09:59 UTC) #10
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-10 19:58:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/231013003/60001
6 years, 8 months ago (2014-04-10 19:58:47 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 22:45:18 UTC) #13
Message was sent while issue was closed.
Change committed as 263105

Powered by Google App Engine
This is Rietveld 408576698