[Interpreter] Remove constant pool type in tests

[Interpreter] Remove constant pool type in tests

For historical reasons, the interpreter's bytecode expectations tests
required a type for the constant pool. This had two disadvantages:

 1. Strings and numbers were not visible in mixed pools, and
 2. Mismatches of pool types (e.g. when rebaselining) would cause parser
    errors

This removes the pool types, making everything 'mixed', but appending
the values to string and number valued constants. Specifying a pool type
in the *.golden header now prints a warning (for backwards compatibility).

BUG=v8:5350
Committed: https://crrev.com/b28b7e13285aac6ab1a8c5d977d08300152504d7
Cr-Commit-Position: refs/heads/master@{#39216}

[Leszek, 2016-09-06 14:37:06]

The CQ bit was checked by leszeks@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 14:37:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek, 2016-09-06 15:11:42]

leszeks@google.com changed reviewers:
+ rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-09-06 15:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 15:19:09]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-09-06 15:28:57]

One comment, but looks great, thanks.

LGTM

https://codereview.chromium.org/2310103002/diff/1/test/cctest/interpreter/gen...
File test/cctest/interpreter/generate-bytecode-expectations.cc (right):

https://codereview.chromium.org/2310103002/diff/1/test/cctest/interpreter/gen...
test/cctest/interpreter/generate-bytecode-expectations.cc:258:
REPORT_WARNING("Pool types are deprecated");
Just drop this branch entirely - there shouldn't be any other expectations files
other than the ones you've updated

[Leszek, 2016-09-06 15:46:10]

The CQ bit was checked by leszeks@google.com

[Leszek, 2016-09-06 15:46:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2310103002/#ps20001
(title: "Remove warning for pool type")

[commit-bot: I haz the power, 2016-09-06 15:46:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 16:10:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 16:11:36]

Description was changed from

==========
[Interpreter] Remove constant pool type in tests

For historical reasons, the interpreter's bytecode expectations tests
required a type for the constant pool. This had two disadvantages:

 1. Strings and numbers were not visible in mixed pools, and
 2. Mismatches of pool types (e.g. when rebaselining) would cause parser
    errors

This removes the pool types, making everything 'mixed', but appending
the values to string and number valued constants. Specifying a pool type
in the *.golden header now prints a warning (for backwards compatibility).

BUG=v8:5350
==========

to

==========
[Interpreter] Remove constant pool type in tests

For historical reasons, the interpreter's bytecode expectations tests
required a type for the constant pool. This had two disadvantages:

 1. Strings and numbers were not visible in mixed pools, and
 2. Mismatches of pool types (e.g. when rebaselining) would cause parser
    errors

This removes the pool types, making everything 'mixed', but appending
the values to string and number valued constants. Specifying a pool type
in the *.golden header now prints a warning (for backwards compatibility).

BUG=v8:5350

Committed: https://crrev.com/b28b7e13285aac6ab1a8c5d977d08300152504d7
Cr-Commit-Position: refs/heads/master@{#39216}
==========

[commit-bot: I haz the power, 2016-09-06 16:11:37]

Patchset 2 (id:??) landed as
https://crrev.com/b28b7e13285aac6ab1a8c5d977d08300152504d7
Cr-Commit-Position: refs/heads/master@{#39216}