Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: test/cctest/interpreter/bytecode-expectations-printer.h

Issue 2310103002: [Interpreter] Remove constant pool type in tests (Closed)
Patch Set: Remove warning for pool type Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/interpreter/bytecode-expectations-printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode-expectations-printer.h
diff --git a/test/cctest/interpreter/bytecode-expectations-printer.h b/test/cctest/interpreter/bytecode-expectations-printer.h
index c64ca90c8159d9ce5903ba6bc0ff87300f850082..93f3c953ac5c75c6ccaf83425757c4d3377947ac 100644
--- a/test/cctest/interpreter/bytecode-expectations-printer.h
+++ b/test/cctest/interpreter/bytecode-expectations-printer.h
@@ -26,17 +26,8 @@ class BytecodeArrayIterator;
class BytecodeExpectationsPrinter final {
public:
- enum class ConstantPoolType {
- kUnknown,
- kString,
- kNumber,
- kMixed,
- };
-
- BytecodeExpectationsPrinter(v8::Isolate* i,
- ConstantPoolType t = ConstantPoolType::kMixed)
+ explicit BytecodeExpectationsPrinter(v8::Isolate* i)
: isolate_(i),
- const_pool_type_(t),
execute_(true),
wrap_(true),
top_level_(false),
@@ -45,11 +36,6 @@ class BytecodeExpectationsPrinter final {
void PrintExpectation(std::ostream& stream, // NOLINT
const std::string& snippet) const;
- void set_constant_pool_type(ConstantPoolType const_pool_type) {
- const_pool_type_ = const_pool_type;
- }
- ConstantPoolType const_pool_type() const { return const_pool_type_; }
-
void set_execute(bool execute) { execute_ = execute; }
bool execute() const { return execute_; }
@@ -110,7 +96,6 @@ class BytecodeExpectationsPrinter final {
}
v8::Isolate* isolate_;
- ConstantPoolType const_pool_type_;
bool execute_;
bool wrap_;
bool top_level_;
« no previous file with comments | « no previous file | test/cctest/interpreter/bytecode-expectations-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698