Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2310063003: GN: turn off ccache (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: turn off ccache I just burned 2 days debugging a confusing interaction between ccache and the -fsanitize-blacklist argument to Clang. Let's see if we can live without ccache (swarming affinity + Ninja seems pretty decent). As a point of reference, the Mac bots have been looking for ccache but failing to find it. They're proof this will be fine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2310063003 Committed: https://skia.googlesource.com/skia/+/b58fe9b89965ba8cbfe4b5630bb1f6cdc2755fda

Patch Set 1 #

Patch Set 2 : android too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -247 lines) Patch
M infra/bots/recipe_modules/flavor/gn_android_flavor.py View 1 1 chunk +0 lines, -9 lines 0 comments Download
M infra/bots/recipe_modules/flavor/gn_flavor.py View 2 chunks +0 lines, -9 lines 0 comments Download
M infra/bots/recipes/swarm_compile.py View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-mipsel-Debug-GN_Android.json View 1 2 chunks +1 line, -33 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Release-GN.json View 2 chunks +1 line, -33 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-arm64-Release-GN_Android.json View 1 2 chunks +1 line, -33 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-x86_64-Debug-GN.json View 2 chunks +1 line, -33 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-GN.json View 2 chunks +1 line, -33 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE.json View 2 chunks +1 line, -31 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Fast.json View 2 chunks +1 line, -31 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 3 months ago (2016-09-06 21:25:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310063003/20001
4 years, 3 months ago (2016-09-06 21:26:09 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-06 21:26:11 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 3 months ago (2016-09-07 03:26:01 UTC) #9
jcgregorio
lgtm
4 years, 3 months ago (2016-09-07 11:01:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310063003/20001
4 years, 3 months ago (2016-09-07 12:11:38 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 12:12:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b58fe9b89965ba8cbfe4b5630bb1f6cdc2755fda

Powered by Google App Engine
This is Rietveld 408576698