Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: infra/bots/recipe_modules/flavor/gn_flavor.py

Issue 2310063003: GN: turn off ccache (Closed)
Patch Set: android too Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « infra/bots/recipe_modules/flavor/gn_android_flavor.py ('k') | infra/bots/recipes/swarm_compile.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipe_modules/flavor/gn_flavor.py
diff --git a/infra/bots/recipe_modules/flavor/gn_flavor.py b/infra/bots/recipe_modules/flavor/gn_flavor.py
index 31b4756be0116842f08683d619c3ec9f3990491f..18a03e1a6e440e8e312e66c4ebb063fb315ef231 100644
--- a/infra/bots/recipe_modules/flavor/gn_flavor.py
+++ b/infra/bots/recipe_modules/flavor/gn_flavor.py
@@ -40,14 +40,6 @@ class GNFlavorUtils(default_flavor.DefaultFlavorUtils):
elif compiler == 'GCC':
cc, cxx = 'gcc', 'g++'
- compiler_prefix = ""
- ccache = self.m.run.ccache()
- if ccache:
- compiler_prefix = ccache
- if compiler == 'Clang':
- # Stifle "argument unused during compilation: ..." warnings.
- extra_cflags.append('-Qunused-arguments')
-
if extra_config == 'Fast':
extra_cflags.extend(['-march=native', '-fomit-frame-pointer', '-O3'])
if extra_config.startswith('SK'):
@@ -57,7 +49,6 @@ class GNFlavorUtils(default_flavor.DefaultFlavorUtils):
gn_args = ' '.join('%s=%s' % (k,v) for (k,v) in sorted({
'cc': quote(cc),
'cxx': quote(cxx),
- 'compiler_prefix': quote(compiler_prefix),
'extra_cflags': quote(' '.join(extra_cflags)),
'extra_ldflags': quote(' '.join(extra_ldflags)),
'is_debug': 'true' if configuration == 'Debug' else 'false',
« no previous file with comments | « infra/bots/recipe_modules/flavor/gn_android_flavor.py ('k') | infra/bots/recipes/swarm_compile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698