third_party/WebKit/LayoutTests/http/tests/budget/reserve.html - Issue 2309863002: Plumb reserve method of the BudgetAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/budget/reserve.html

Issue 2309863002: Plumb reserve method of the BudgetAPI (Closed)

Patch Set: Rename BudgetServiceErrorType::NO_ERROR to ::NONE to avoid Windows constant name clash. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html ('k') | third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/budget/reserve.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html b/third_party/WebKit/LayoutTests/http/tests/budget/reserve.html

similarity index 55%

copy from third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html

copy to third_party/WebKit/LayoutTests/http/tests/budget/reserve.html

index 66290d7c268dce6855cbe5f0c040dc40874562ee..5b373015c4a2d135342a43233b349fa765275021 100644

--- a/third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html

+++ b/third_party/WebKit/LayoutTests/http/tests/budget/reserve.html

@@ -1,7 +1,7 @@

<!doctype html>

<html>

<head>

- <title>Budget API: Make basic getCost calls.</title>

+ <title>Budget API: Make basic reserve calls.</title>

@@ -15,23 +15,24 @@

promise_test(function() {

return budgetServiceMock.then(mock => {

assert_own_property(Navigator.prototype, 'budget');

- return navigator.budget.getCost("silent-push");

- }).then(cost => {

- assert_equals(cost, TEST_BUDGET_COST);

+ mock.setReserveSuccess(true);

+ return navigator.budget.reserve("silent-push");

+ }).then(success => {

+ assert_equals(success, true);

});

- }, 'BudgetService.GetCost should return correct results.');

+ }, 'BudgetService.Reserve should return correct results.');

promise_test(function() {

return budgetServiceMock.then(mock => {

assert_own_property(Navigator.prototype, 'budget');

- return navigator.budget.getCost("frobinator");

- }).then(cost => {

- assert_unreached('getCost should have failed with an invalid argument.');

+ return navigator.budget.reserve("frobinator");

+ }).then(success => {

+ assert_unreached('reserve should have failed with an invalid argument.');

}, function(error) {

assert_equals(error.name, 'TypeError');

- assert_equals(error.message, "Failed to execute 'getCost' on 'BudgetService': The provided value 'frobinator' is not a valid enum value of type ActionType.");

+ assert_equals(error.message, "Failed to execute 'reserve' on 'BudgetService': The provided value 'frobinator' is not a valid enum value of type OperationType.");

});

- }, 'BudgetService.GetCost should return Type Error if an invalid argument is provided.');

+ }, 'BudgetService.Reserve should return Type Error if an invalid argument is provided.');

</script>

</body>

</html>