third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html - Issue 2309863002: Plumb reserve method of the BudgetAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

Issue 2309863002: Plumb reserve method of the BudgetAPI (Closed)

Patch Set: Rename BudgetServiceErrorType::NO_ERROR to ::NONE to avoid Windows constant name clash. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/budget/reserve.html ('k') | third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html b/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

similarity index 77%

copy from third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html

copy to third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

index c1416e80e8a1083277bc36a499eab74e50d194f8..e8112b0276e348f4e4dca0eb564efa822a552d54 100644

--- a/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html

+++ b/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

@@ -1,7 +1,7 @@

<!DOCTYPE html>

<html>

<head>

- <title>getCost succeeds from a Service Worker</title>

+ <title>reserve succeeds from a Service Worker</title>

@@ -17,25 +17,25 @@

var port;

budgetServiceMock.then(mock => {

+ mock.setReserveSuccess(true);

getActiveServiceWorkerWithMessagePort(test, script, scope)

.then(function(workerInfo) {

port = workerInfo.port;

- port.postMessage({command: 'getCost'});

+ port.postMessage({ command: 'reserve' });

port.addEventListener('message', function(event) {

if (typeof event.data != 'object' || !event.data.command)

assert_unreached('Invalid message from the service worker');

- assert_equals(event.data.command, 'getCost');

+ assert_equals(event.data.command, 'reserve');

assert_true(event.data.success,

- 'getCost should succeed. Error message: ' + event.data.errorMessage);

- assert_equals(event.data.cost, TEST_BUDGET_COST);

+ 'reserve should succeed. Error message: ' + event.data.errorMessage);

test.done();

});

})

.catch(unreached_rejection(test));

});

- }, 'getCost should succeed from Service Worker');

+ }, 'reserve should succeed from Service Worker');

</script>

</body>

</html>