Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2309563002: Check if BubbleReference weak pointer is valid before using it in the chooser (Closed)

Created:
4 years, 3 months ago by juncai
Modified:
4 years, 3 months ago
Reviewers:
Robert Sesek, msw
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if BubbleReference weak pointer is valid before using it in the chooser Since BubbleReference is a base::WeakPtr<BubbleController>, before using it, needs to check if it is valid. This CL added code to do it. BUG=642748 Committed: https://crrev.com/76f6b1648624d9fe6ce48b7d5996e3c2d41ec710 Cr-Commit-Position: refs/heads/master@{#416698}

Patch Set 1 : check if BubbleReference weak pointer is valid before using it in the chooser #

Patch Set 2 : ran "git cl upload" twice, same as the previous patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
juncai
rsesek@chromium.org: Please review changes in //chrome/browser/ui/cocoa msw@chromium.org: Please review changes in //chrome/browser/ui/views/
4 years, 3 months ago (2016-09-02 23:25:54 UTC) #4
Robert Sesek
lgtm
4 years, 3 months ago (2016-09-06 15:40:25 UTC) #7
msw
lgtm
4 years, 3 months ago (2016-09-06 19:15:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309563002/20001
4 years, 3 months ago (2016-09-06 19:26:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 20:24:12 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:26:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76f6b1648624d9fe6ce48b7d5996e3c2d41ec710
Cr-Commit-Position: refs/heads/master@{#416698}

Powered by Google App Engine
This is Rietveld 408576698