Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Issue 2309563002: Check if BubbleReference weak pointer is valid before using it in the chooser (Closed)
Patch Set: ran "git cl upload" twice, same as the previous patch. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
index bf44f5637a14668ae6416eed713ef5c1d05599e7..dba5e9a55e40f79a0cc5deb0176220f02f2b0759 100644
--- a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
+++ b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
@@ -266,14 +266,16 @@ std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {
- (void)onConnect:(id)sender {
buttonPressed_ = true;
[chooserContentView_ accept];
- self.bubbleReference->CloseBubble(BUBBLE_CLOSE_ACCEPTED);
+ if (self.bubbleReference)
+ self.bubbleReference->CloseBubble(BUBBLE_CLOSE_ACCEPTED);
[self close];
}
- (void)onCancel:(id)sender {
buttonPressed_ = true;
[chooserContentView_ cancel];
- self.bubbleReference->CloseBubble(BUBBLE_CLOSE_CANCELED);
+ if (self.bubbleReference)
+ self.bubbleReference->CloseBubble(BUBBLE_CLOSE_CANCELED);
[self close];
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698