Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2543)

Unified Diff: chrome/renderer/chrome_render_process_observer.cc

Issue 230953004: Temporarily CHECK(trial) in ChromeRenderProcessObserver::OnSetFieldTrialGroup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove this check after the investigation of 359406 is complete Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_process_observer.cc
diff --git a/chrome/renderer/chrome_render_process_observer.cc b/chrome/renderer/chrome_render_process_observer.cc
index 1983712a795f555d589f4059ae81e27887e5387d..cbd1b4b9ad36bb9958e61226baec81f2350a558d 100644
--- a/chrome/renderer/chrome_render_process_observer.cc
+++ b/chrome/renderer/chrome_render_process_observer.cc
@@ -392,6 +392,8 @@ void ChromeRenderProcessObserver::OnSetFieldTrialGroup(
const std::string& group_name) {
base::FieldTrial* trial =
base::FieldTrialList::CreateFieldTrial(field_trial_name, group_name);
+ // TODO(mef): Remove this check after the investigation of 359406 is complete.
+ CHECK(trial) << field_trial_name << ":" << group_name;
// Ensure the trial is marked as "used" by calling group() on it. This is
// needed to ensure the trial is properly reported in renderer crash reports.
trial->group();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698