Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: chrome/renderer/chrome_render_process_observer.cc

Issue 230953004: Temporarily CHECK(trial) in ChromeRenderProcessObserver::OnSetFieldTrialGroup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove this check after the investigation of 359406 is complete Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_render_process_observer.h" 5 #include "chrome/renderer/chrome_render_process_observer.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/allocator/allocator_extension.h" 10 #include "base/allocator/allocator_extension.h"
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 if (webkit_initialized_) 385 if (webkit_initialized_)
386 WebCache::getResourceTypeStats(&stats); 386 WebCache::getResourceTypeStats(&stats);
387 RenderThread::Get()->Send(new ChromeViewHostMsg_ResourceTypeStats(stats)); 387 RenderThread::Get()->Send(new ChromeViewHostMsg_ResourceTypeStats(stats));
388 } 388 }
389 389
390 void ChromeRenderProcessObserver::OnSetFieldTrialGroup( 390 void ChromeRenderProcessObserver::OnSetFieldTrialGroup(
391 const std::string& field_trial_name, 391 const std::string& field_trial_name,
392 const std::string& group_name) { 392 const std::string& group_name) {
393 base::FieldTrial* trial = 393 base::FieldTrial* trial =
394 base::FieldTrialList::CreateFieldTrial(field_trial_name, group_name); 394 base::FieldTrialList::CreateFieldTrial(field_trial_name, group_name);
395 // TODO(mef): Remove this check after the investigation of 359406 is complete.
396 CHECK(trial) << field_trial_name << ":" << group_name;
395 // Ensure the trial is marked as "used" by calling group() on it. This is 397 // Ensure the trial is marked as "used" by calling group() on it. This is
396 // needed to ensure the trial is properly reported in renderer crash reports. 398 // needed to ensure the trial is properly reported in renderer crash reports.
397 trial->group(); 399 trial->group();
398 chrome_variations::SetChildProcessLoggingVariationList(); 400 chrome_variations::SetChildProcessLoggingVariationList();
399 } 401 }
400 402
401 void ChromeRenderProcessObserver::OnGetV8HeapStats() { 403 void ChromeRenderProcessObserver::OnGetV8HeapStats() {
402 HeapStatisticsCollector::Instance()->InitiateCollection(); 404 HeapStatisticsCollector::Instance()->InitiateCollection();
403 } 405 }
404 406
405 void ChromeRenderProcessObserver::ExecutePendingClearCache() { 407 void ChromeRenderProcessObserver::ExecutePendingClearCache() {
406 if (clear_cache_pending_ && webkit_initialized_) { 408 if (clear_cache_pending_ && webkit_initialized_) {
407 clear_cache_pending_ = false; 409 clear_cache_pending_ = false;
408 WebCache::clear(); 410 WebCache::clear();
409 } 411 }
410 } 412 }
411 413
412 const RendererContentSettingRules* 414 const RendererContentSettingRules*
413 ChromeRenderProcessObserver::content_setting_rules() const { 415 ChromeRenderProcessObserver::content_setting_rules() const {
414 return &content_setting_rules_; 416 return &content_setting_rules_;
415 } 417 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698