Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 230953004: Temporarily CHECK(trial) in ChromeRenderProcessObserver::OnSetFieldTrialGroup. (Closed)

Created:
6 years, 8 months ago by mef
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Temporarily CHECK(trial) in ChromeRenderProcessObserver::OnSetFieldTrialGroup. BUG=359406 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262845

Patch Set 1 #

Patch Set 2 : Remove this check after the investigation of 359406 is complete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/renderer/chrome_render_process_observer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mef
6 years, 8 months ago (2014-04-09 18:48:34 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 8 months ago (2014-04-09 18:54:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/230953004/1
6 years, 8 months ago (2014-04-09 18:55:37 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 19:39:34 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60434
6 years, 8 months ago (2014-04-09 19:39:35 UTC) #5
mef
Hi Lei, could you OWNER-review the temporary CHECK in ChromeRenderProcessObserver::OnSetFieldTrialGroup? thanks, -m
6 years, 8 months ago (2014-04-09 19:51:05 UTC) #6
Lei Zhang
lgtm Please add a TODO to remove this after the investigation is complete.
6 years, 8 months ago (2014-04-09 20:00:07 UTC) #7
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-09 20:25:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/230953004/20001
6 years, 8 months ago (2014-04-09 20:25:15 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 22:45:42 UTC) #10
Message was sent while issue was closed.
Change committed as 262845

Powered by Google App Engine
This is Rietveld 408576698