Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2309493002: Revert of [css-flexbox] align-content should apply even when there's just a single line (patchset #… (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert of [css-flexbox] align-content should apply even when there's just a single line (patchset #2 id:20001 of https://codereview.chromium.org/2191683003/ ) Reason for revert: Caused multiple regressions (bug 634672, bug 641789) and I'd like more time to investigate them before shipping this to users. Original issue's description: > [css-flexbox] align-content should apply even when there's just a single line > > In Jan 2015 the spec changed in > https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping > > Change our code accordingly. This effectively reverts commit > 764735dc12285a09a32b7d5ad3a8d6f178b0ab83 > > BUG=599828 > R=eae@chromium.org,dgrogan@chromium.org > > Committed: https://crrev.com/955a53c8bc7f04b4830acabf7291c603314e0a53 > Cr-Commit-Position: refs/heads/master@{#408456} TBR=dgrogan@chromium.org,eae@chromium.org BUG=599828, 634672, 641789 Review-Url: https://codereview.chromium.org/2289793003 Cr-Commit-Position: refs/heads/master@{#415844} (cherry picked from commit 112c0577ad48a4cfe0b6046364f67bd97dc14eff) Committed: https://chromium.googlesource.com/chromium/src/+/829b6a7b22da492c51544d1f0e97ac23b5919467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -47 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html View 2 chunks +15 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flexbox-wordwrap.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-content.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 3 months ago (2016-09-02 18:59:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
829b6a7b22da492c51544d1f0e97ac23b5919467.

Powered by Google App Engine
This is Rietveld 408576698