Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2289793003: Revert of [css-flexbox] align-content should apply even when there's just a single line (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [css-flexbox] align-content should apply even when there's just a single line (patchset #2 id:20001 of https://codereview.chromium.org/2191683003/ ) Reason for revert: Caused multiple regressions (bug 634672, bug 641789) and I'd like more time to investigate them before shipping this to users. Original issue's description: > [css-flexbox] align-content should apply even when there's just a single line > > In Jan 2015 the spec changed in > https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping > > Change our code accordingly. This effectively reverts commit > 764735dc12285a09a32b7d5ad3a8d6f178b0ab83 > > BUG=599828 > R=eae@chromium.org,dgrogan@chromium.org > > Committed: https://crrev.com/955a53c8bc7f04b4830acabf7291c603314e0a53 > Cr-Commit-Position: refs/heads/master@{#408456} TBR=dgrogan@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=599828, 634672, 641789 Committed: https://crrev.com/112c0577ad48a4cfe0b6046364f67bd97dc14eff Cr-Commit-Position: refs/heads/master@{#415844}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -47 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html View 1 2 chunks +15 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flexbox-wordwrap.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-content.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
cbiesinger
Created Revert of [css-flexbox] align-content should apply even when there's just a single line
4 years, 3 months ago (2016-08-29 21:44:38 UTC) #2
eae
LGTM :(
4 years, 3 months ago (2016-08-29 22:23:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289793003/1
4 years, 3 months ago (2016-08-29 22:30:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/120343) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 3 months ago (2016-08-30 03:42:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289793003/140001
4 years, 3 months ago (2016-09-01 00:23:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 3 months ago (2016-09-01 01:55:24 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 01:57:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/112c0577ad48a4cfe0b6046364f67bd97dc14eff
Cr-Commit-Position: refs/heads/master@{#415844}

Powered by Google App Engine
This is Rietveld 408576698