Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2309403003: Forward --password-store switch to os_crypt (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Forward --password-store switch to os_crypt Password manager uses a switch to allow the user to override the auto-detection of the appropriate password store. OSCrypt should respect this switch as well. The switch value is read and passed to OSCrypt at a very early point in Chrome's start, before any of OSCrypt's dependents use it. I also reworked OSCrypt's build to make it simpler for chrome to deduce whether the linux implementation of OSCrypt will be used. - Previously, os_crypt_linux was used only if we also decided to link at least one linux backend. Otherwise we used os_crypt_posix. + Now, we always use the linux implementation for linux. If no KeyStorage is linked, the linux implementation defaults to the same behavior as for posix. This CL is a fixed version of https://codereview.chromium.org/2118443002/ Note: old BUG was 602624, but the merge approval is at 643189. BUG=643189 Review-Url: https://codereview.chromium.org/2159743002 Cr-Commit-Position: refs/heads/master@{#406056} (cherry picked from commit 3ea4c69178fd68bcdc880bc2c83481e57e293403) Committed: https://chromium.googlesource.com/chromium/src/+/1673c9e4ac994c620bc08a7ee9cd963515a26fb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -15 lines) Patch
M chrome/browser/chrome_browser_main_linux.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/os_crypt.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M components/os_crypt/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/os_crypt/key_storage_linux.h View 1 chunk +4 lines, -2 lines 0 comments Download
M components/os_crypt/key_storage_linux.cc View 1 chunk +45 lines, -3 lines 0 comments Download
M components/os_crypt/os_crypt.h View 4 chunks +11 lines, -5 lines 0 comments Download
M components/os_crypt/os_crypt_linux.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
4 years, 3 months ago (2016-09-06 08:47:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1673c9e4ac994c620bc08a7ee9cd963515a26fb4.

Powered by Google App Engine
This is Rietveld 408576698