Forward --password-store switch to os_crypt

Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version of https://codereview.chromium.org/2118443002/

BUG=602624
Committed: https://crrev.com/3ea4c69178fd68bcdc880bc2c83481e57e293403
Cr-Commit-Position: refs/heads/master@{#406056}

[cfroussios, 2016-07-18 13:41:51]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 13:42:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-07-18 13:42:54]

Description was changed from

==========
Forward --password-store switch to os_crypt

BUG=602624
==========

to

==========
Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version https://codereview.chromium.org/2118443002/

BUG=602624
==========

[cfroussios, 2016-07-18 13:51:35]

Description was changed from

==========
Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version https://codereview.chromium.org/2118443002/

BUG=602624
==========

to

==========
Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version of https://codereview.chromium.org/2118443002/

BUG=602624
==========

[cfroussios, 2016-07-18 14:05:58]

cfroussios@chromium.org changed reviewers:
+ thestig@chromium.org

[cfroussios, 2016-07-18 14:05:58]

Hi! I restarted with a clean CL. This should not be different from the the
previous CL, expect that the switch is forwarded before that initialization of
the profile. Could you review again? Thanks!

[commit-bot: I haz the power, 2016-07-18 14:40:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:40:28]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-07-18 19:06:44]

On 2016/07/18 14:05:58, cfroussios wrote:
> Hi! I restarted with a clean CL. This should not be different from the the
> previous CL, expect that the switch is forwarded before that initialization of
> the profile. Could you review again? Thanks!

Sure. Looking. It would have been helpful to upload r405114 as patch set 1, and
the fix as patch set 2. Then it would be easy to diff the two. I'll just diff
manually.

[Lei Zhang, 2016-07-18 19:08:57]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-07-18 19:08:58]

lgtm

Looks like we just moved the OSCrypt::SetStore() call from
ChromeBrowserMainPartsLinux::PostProfileInit() to
ChromeBrowserMainPartsLinux::PreProfileInit().

[commit-bot: I haz the power, 2016-07-18 19:09:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 19:15:27]

Description was changed from

==========
Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version of https://codereview.chromium.org/2118443002/

BUG=602624
==========

to

==========
Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version of https://codereview.chromium.org/2118443002/

BUG=602624
==========

[commit-bot: I haz the power, 2016-07-18 19:15:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-18 19:15:34]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 19:17:17]

Description was changed from

==========
Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version of https://codereview.chromium.org/2118443002/

BUG=602624
==========

to

==========
Forward --password-store switch to os_crypt

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version of https://codereview.chromium.org/2118443002/

BUG=602624

Committed: https://crrev.com/3ea4c69178fd68bcdc880bc2c83481e57e293403
Cr-Commit-Position: refs/heads/master@{#406056}
==========

[commit-bot: I haz the power, 2016-07-18 19:17:18]

Patchset 1 (id:??) landed as
https://crrev.com/3ea4c69178fd68bcdc880bc2c83481e57e293403
Cr-Commit-Position: refs/heads/master@{#406056}