third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp - Issue 2309403002: Use the URL passed to navigator.share().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

Issue 2309403002: Use the URL passed to navigator.share(). (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webshare/share-success.html ('K') | « third_party/WebKit/LayoutTests/webshare/share-without-user-gesture.html ('k') | third_party/WebKit/public/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

diff --git a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

index 6fb373c3c4938c80e61e10848e91c9b51dd4cdcd..1613a2b0ad36b107182e28750e372a8600804116 100644

--- a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

+++ b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

@@ -104,8 +104,11 @@ ScriptPromise NavigatorShare::share(ScriptState* scriptState, const ShareData& s

m_clients.add(client);

ScriptPromise promise = resolver->promise();

- // TODO(sammc): Use shareData.url().

- m_service->Share(shareData.hasTitle() ? shareData.title() : emptyString(), shareData.hasText() ? shareData.text() : emptyString(), convertToBaseCallback(WTF::bind(&ShareClientImpl::callback, wrapPersistent(client))));

+ m_service->Share(

+ shareData.hasTitle() ? shareData.title() : emptyString(),

+ shareData.hasText() ? shareData.text() : emptyString(),

+ shareData.hasURL() ? KURL(scriptState->getExecutionContext()->url(), shareData.url()) : KURL(),

dcheng 2016/09/08 03:17:37 Should this be using doc->completeURL(shareData.ur

Sam McNally 2016/09/08 03:32:05 Done.

+ convertToBaseCallback(WTF::bind(&ShareClientImpl::callback, wrapPersistent(client))));

return promise;

}