Chromium Code Reviews| Index: third_party/WebKit/LayoutTests/webshare/share-success.html |
| diff --git a/third_party/WebKit/LayoutTests/webshare/share-success.html b/third_party/WebKit/LayoutTests/webshare/share-success.html |
| index 79000b50d59d01e1b93824c30c280c8dd931d28c..d5d943639351992562dc70a085d9093d5d689189 100644 |
| --- a/third_party/WebKit/LayoutTests/webshare/share-success.html |
| +++ b/third_party/WebKit/LayoutTests/webshare/share-success.html |
| @@ -5,15 +5,50 @@ |
| <script src="resources/mock-share-service.js"></script> |
| <script> |
| +function getAbsoluteUrl(url) { |
| + return new URL(url, location).toString(); |
| +} |
| + |
| share_test((t, mock) => { |
| - mock.pushShareResult('the title', 'the message', null); |
| + let url = 'https://www.example.com/some/path?some_query#some_fragment'; |
| + mock.pushShareResult('the title', 'the message', getAbsoluteUrl(url), null); |
|
Matt Giuca
2016/09/06 04:18:12
Opinion: Don't use getAbsoluteURL, instead just ha
Matt Giuca
2016/09/06 04:24:00
As discussed, too hard to predict what the URL wil
|
| return callWithKeyDown(() => navigator.share( |
| - {title: 'the title', text: 'the message', url: 'the URL'})); |
| + {title: 'the title', text: 'the message', url: url})); |
| }, 'successful share'); |
| share_test((t, mock) => { |
| - mock.pushShareResult('', '', null); |
| + mock.pushShareResult('', '', '', null); |
| return callWithKeyDown(() => navigator.share({})); |
| }, 'successful share with empty ShareData'); |
| +share_test((t, mock) => { |
| + let url = '//www.example.com/some/path?some_query#some_fragment'; |
| + mock.pushShareResult('', '', getAbsoluteUrl(url), null); |
| + return callWithKeyDown(() => navigator.share({url: url})); |
| +}, 'successful share with URL without a scheme'); |
| + |
| +share_test((t, mock) => { |
| + let url = '/some/path?some_query#some_fragment'; |
| + mock.pushShareResult('', '', getAbsoluteUrl(url), null); |
| + return callWithKeyDown(() => navigator.share({url: url})); |
| +}, 'successful share with a path-only URL'); |
| + |
| +share_test((t, mock) => { |
| + let url = 'foo'; |
| + mock.pushShareResult('', '', getAbsoluteUrl(url), null); |
| + return callWithKeyDown(() => navigator.share({url: url})); |
| +}, 'successful share with a relative URL'); |
| + |
| +share_test((t, mock) => { |
| + let url = ''; |
| + mock.pushShareResult('', '', getAbsoluteUrl(url), null); |
| + return callWithKeyDown(() => navigator.share({url: url})); |
| +}, 'successful share with an empty URL'); |
| + |
| +share_test((t, mock) => { |
| + let url = 'data:foo'; |
| + mock.pushShareResult('', '', getAbsoluteUrl(url), null); |
| + return callWithKeyDown(() => navigator.share({url: url})); |
| +}, 'successful share with a data URL'); |
| + |
| </script> |